Skip to content

Commit 51b4e9a

Browse files
committed
Make a couple parameters in the BuildTarget initializer defaulted
1 parent 34f9772 commit 51b4e9a

File tree

6 files changed

+3
-13
lines changed

6 files changed

+3
-13
lines changed

Sources/BuildServerProtocol/SupportTypes/BuildTarget.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ public struct BuildTarget: Codable, Hashable, Sendable {
6868

6969
public init(
7070
id: BuildTargetIdentifier,
71-
displayName: String?,
72-
baseDirectory: URI?,
73-
tags: [BuildTargetTag],
71+
displayName: String? = nil,
72+
baseDirectory: URI? = nil,
73+
tags: [BuildTargetTag] = [],
7474
capabilities: BuildTargetCapabilities,
7575
languageIds: [Language],
7676
dependencies: [BuildTargetIdentifier],

Sources/BuildSystemIntegration/FixedCompilationDatabaseBuildSystem.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ package actor FixedCompilationDatabaseBuildSystem: BuiltInBuildSystem {
8484
return WorkspaceBuildTargetsResponse(targets: [
8585
BuildTarget(
8686
id: .dummy,
87-
displayName: nil,
88-
baseDirectory: nil,
8987
tags: [.test],
9088
capabilities: BuildTargetCapabilities(),
9189
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/JSONCompilationDatabaseBuildSystem.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ package actor JSONCompilationDatabaseBuildSystem: BuiltInBuildSystem {
102102
}
103103
return BuildTarget(
104104
id: try BuildTargetIdentifier.createCompileCommands(compiler: compiler),
105-
displayName: nil,
106-
baseDirectory: nil,
107105
tags: [.test],
108106
capabilities: BuildTargetCapabilities(),
109107
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/LegacyBuildServerBuildSystem.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ actor LegacyBuildServerBuildSystem: MessageHandler, BuiltInBuildSystem {
145145
BuildTarget(
146146
id: .dummy,
147147
displayName: "BuildServer",
148-
baseDirectory: nil,
149148
tags: [.test],
150149
capabilities: BuildTargetCapabilities(),
151150
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/SwiftPMBuildSystem.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,6 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
511511
return BuildTarget(
512512
id: targetId,
513513
displayName: target.name,
514-
baseDirectory: nil,
515514
tags: tags,
516515
capabilities: BuildTargetCapabilities(),
517516
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.
@@ -525,7 +524,6 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
525524
BuildTarget(
526525
id: .forPackageManifest,
527526
displayName: "Package.swift",
528-
baseDirectory: nil,
529527
tags: [.notBuildable],
530528
capabilities: BuildTargetCapabilities(),
531529
languageIds: [.swift],

Sources/SKTestSupport/CustomBuildServerTestProject.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,6 @@ package extension CustomBuildServer {
148148
return WorkspaceBuildTargetsResponse(targets: [
149149
BuildTarget(
150150
id: .dummy,
151-
displayName: nil,
152-
baseDirectory: nil,
153-
tags: [],
154151
capabilities: BuildTargetCapabilities(),
155152
languageIds: [],
156153
dependencies: []

0 commit comments

Comments
 (0)