Merge pull request #1303 from ahoppen/review-comments-1216

Address review comment to #1216

Author: ahoppen

Sources/SKSupport/SwitchableProcessResultExitStatus.swift

@@ -10,7 +10,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-// We need to import all of TSCBasic because otherwise we can't refer to Process.ExitStatus (rdar://127577691)
 import struct TSCBasic.ProcessResult
 
 /// Same as `ProcessResult.ExitStatus` in tools-support-core but has the same cases on all platforms and is thus easier

Sources/SemanticIndex/UpdateIndexStoreTaskDescription.swift

@@ -118,14 +118,6 @@ public struct UpdateIndexStoreTaskDescription: IndexTaskDescription {
       logger.error("Not indexing \(uri.forLogging) because it has no compiler arguments")
       return
     }
-    guard !buildSettings.isFallback else {
-      // Only index with real build settings. Indexing with fallback arguments could result in worse results than not
-      // indexing at all: If a file has been indexed with real build settings before, had a tiny modification made but
-      // we don't have any real build settings when it should get re-indexed. Then it's better to have the stale index
-      // from correct compiler arguments than no index at all.
-      logger.error("Not updating index store for \(uri.forLogging) because it has fallback compiler arguments")
-      return
-    }
     guard let toolchain = await buildSystemManager.toolchain(for: uri, language) else {
       logger.error(
         "Not updating index store for \(uri.forLogging) because no toolchain could be determined for the document"