Skip to content

Commit 70c6d82

Browse files
committed
Make a couple parameters in the BuildTarget initializer defaulted
1 parent 33f4101 commit 70c6d82

File tree

6 files changed

+3
-13
lines changed

6 files changed

+3
-13
lines changed

Sources/BuildServerProtocol/SupportTypes/BuildTarget.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ public struct BuildTarget: Codable, Hashable, Sendable {
7272

7373
public init(
7474
id: BuildTargetIdentifier,
75-
displayName: String?,
76-
baseDirectory: URI?,
77-
tags: [BuildTargetTag],
75+
displayName: String? = nil,
76+
baseDirectory: URI? = nil,
77+
tags: [BuildTargetTag] = [],
7878
capabilities: BuildTargetCapabilities,
7979
languageIds: [Language],
8080
dependencies: [BuildTargetIdentifier],

Sources/BuildSystemIntegration/FixedCompilationDatabaseBuildSystem.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ package actor FixedCompilationDatabaseBuildSystem: BuiltInBuildSystem {
9191
return WorkspaceBuildTargetsResponse(targets: [
9292
BuildTarget(
9393
id: .dummy,
94-
displayName: nil,
95-
baseDirectory: nil,
9694
tags: [.test],
9795
capabilities: BuildTargetCapabilities(),
9896
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/JSONCompilationDatabaseBuildSystem.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,6 @@ package actor JSONCompilationDatabaseBuildSystem: BuiltInBuildSystem {
110110
}
111111
return BuildTarget(
112112
id: try BuildTargetIdentifier.createCompileCommands(compiler: compiler),
113-
displayName: nil,
114-
baseDirectory: nil,
115113
tags: [.test],
116114
capabilities: BuildTargetCapabilities(),
117115
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/LegacyBuildServerBuildSystem.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ actor LegacyBuildServerBuildSystem: MessageHandler, BuiltInBuildSystem {
145145
BuildTarget(
146146
id: .dummy,
147147
displayName: "BuildServer",
148-
baseDirectory: nil,
149148
tags: [.test],
150149
capabilities: BuildTargetCapabilities(),
151150
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.

Sources/BuildSystemIntegration/SwiftPMBuildSystem.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,6 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
522522
return BuildTarget(
523523
id: targetId,
524524
displayName: target.name,
525-
baseDirectory: nil,
526525
tags: tags,
527526
capabilities: BuildTargetCapabilities(),
528527
// Be conservative with the languages that might be used in the target. SourceKit-LSP doesn't use this property.
@@ -536,7 +535,6 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
536535
BuildTarget(
537536
id: .forPackageManifest,
538537
displayName: "Package.swift",
539-
baseDirectory: nil,
540538
tags: [.notBuildable],
541539
capabilities: BuildTargetCapabilities(),
542540
languageIds: [.swift],

Sources/SKTestSupport/CustomBuildServerTestProject.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,6 @@ package extension CustomBuildServer {
156156
return WorkspaceBuildTargetsResponse(targets: [
157157
BuildTarget(
158158
id: .dummy,
159-
displayName: nil,
160-
baseDirectory: nil,
161-
tags: [],
162159
capabilities: BuildTargetCapabilities(),
163160
languageIds: [],
164161
dependencies: []

0 commit comments

Comments
 (0)