Move semaphore signaling to block main thread until request has received a reply instead of until it has been handled

ahoppen · ahoppen · commit 70f99031449d · 2023-09-28T22:28:50.000-07:00
This was causing the sourcekit-lsp integration test to fail.
diff --git a/Sources/LanguageServerProtocolJSONRPC/JSONRPCConnection.swift b/Sources/LanguageServerProtocolJSONRPC/JSONRPCConnection.swift
@@ -290,8 +290,8 @@ public final class JSONRPCConnection {
       messageHandlingQueue.async {
         await request._handle(self.receiveHandler!, id: id, connection: self) { (response, id) in
           self.sendReply(response, id: id)
+          semaphore?.signal()
         }
-        semaphore?.signal()
       }
       semaphore?.wait()
 

Original file line number	Diff line number	Diff line change
`@@ -290,8 +290,8 @@ public final class JSONRPCConnection {`
`290`	`290`	`messageHandlingQueue.async {`
`291`	`291`	`await request._handle(self.receiveHandler!, id: id, connection: self) { (response, id) in`
`292`	`292`	`self.sendReply(response, id: id)`
	`293`	`+ semaphore?.signal()`
`293`	`294`	`}`
`294`		`- semaphore?.signal()`
`295`	`295`	`}`
`296`	`296`	`semaphore?.wait()`
`297`	`297`