Skip to content

Commit 71dfd48

Browse files
committed
Remove CancellationToken
This is no longer needed because we handle cancellation on the `Task` level.
1 parent 3d17cad commit 71dfd48

File tree

7 files changed

+3
-49
lines changed

7 files changed

+3
-49
lines changed

Sources/LSPTestSupport/TestJSONRPCConnection.swift

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,7 @@ public final class TestMessageHandler: MessageHandler {
129129
from clientID: ObjectIdentifier,
130130
reply: @escaping (LSPResult<R.Response>) -> Void
131131
) {
132-
let cancellationToken = CancellationToken()
133-
134-
let request = Request(params, id: id, clientID: clientID, cancellation: cancellationToken, reply: reply)
132+
let request = Request(params, id: id, clientID: clientID, reply: reply)
135133

136134
guard !oneShotRequestHandlers.isEmpty else {
137135
fatalError("unexpected request \(request)")
@@ -179,14 +177,11 @@ public final class TestServer: MessageHandler {
179177
from clientID: ObjectIdentifier,
180178
reply: @escaping (LSPResult<R.Response>) -> Void
181179
) {
182-
let cancellationToken = CancellationToken()
183-
184180
if let params = params as? EchoRequest {
185181
let req = Request(
186182
params,
187183
id: id,
188184
clientID: clientID,
189-
cancellation: cancellationToken,
190185
reply: { result in
191186
reply(result.map({ $0 as! R.Response }))
192187
}
@@ -197,7 +192,6 @@ public final class TestServer: MessageHandler {
197192
params,
198193
id: id,
199194
clientID: clientID,
200-
cancellation: cancellationToken,
201195
reply: { result in
202196
reply(result.map({ $0 as! R.Response }))
203197
}

Sources/LanguageServerProtocol/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
add_library(LanguageServerProtocol STATIC
22
AsyncQueue.swift
3-
Cancellation.swift
43
Connection.swift
54
CustomCodable.swift
65
Error.swift

Sources/LanguageServerProtocol/Cancellation.swift

Lines changed: 0 additions & 27 deletions
This file was deleted.

Sources/LanguageServerProtocol/Connection.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,9 @@ extension Connection {
157157
/// use the version with a completion handler.
158158
public func send<R: RequestType>(_ request: R) async throws -> R.Response {
159159
let requestIDWrapper = ThreadSafeBox<RequestID?>(initialValue: nil)
160-
try Task.checkCancellation()
161160
return try await withTaskCancellationHandler {
162-
try await withCheckedThrowingContinuation { continuation in
161+
try Task.checkCancellation()
162+
return try await withCheckedThrowingContinuation { continuation in
163163
let requestID = self.send(request) { result in
164164
continuation.resume(with: result)
165165
}

Sources/LanguageServerProtocol/Request.swift

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,15 @@ public final class Request<R: RequestType> {
3838
}
3939
}
4040

41-
/// The request's cancellation state.
42-
public let cancellationToken: CancellationToken
43-
4441
public init(
4542
_ request: Params,
4643
id: RequestID,
4744
clientID: ObjectIdentifier,
48-
cancellation: CancellationToken,
4945
reply: @escaping (LSPResult<Response>) -> Void
5046
) {
5147
self.id = id
5248
self.clientID = clientID
5349
self.params = request
54-
self.cancellationToken = cancellation
5550
self.replyBlock = reply
5651
}
5752

@@ -71,9 +66,6 @@ public final class Request<R: RequestType> {
7166
public func reply(_ result: Response) {
7267
reply(.success(result))
7368
}
74-
75-
/// Whether the result has been cancelled.
76-
public var isCancelled: Bool { return cancellationToken.isCancelled }
7769
}
7870

7971
/// A request object, wrapping the parameters of a `NotificationType`.

Sources/SourceKitLSP/Clang/ClangLanguageServer.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ actor ClangLanguageServerShim: ToolchainLanguageServer, MessageHandler {
298298
params,
299299
id: id,
300300
clientID: clientID,
301-
cancellation: CancellationToken(),
302301
reply: { result in
303302
reply(result)
304303
}

Sources/SourceKitLSP/SourceKitServer.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -703,13 +703,10 @@ extension SourceKitServer: MessageHandler {
703703
) async {
704704
let startDate = Date()
705705

706-
let cancellationToken = CancellationToken()
707-
708706
let request = Request(
709707
params,
710708
id: id,
711709
clientID: clientID,
712-
cancellation: cancellationToken,
713710
reply: { [weak self] result in
714711
reply(result)
715712
let endDate = Date()

0 commit comments

Comments
 (0)