Continue iterating if an ExpressionTypeInfo fails to deserialize

fwcd · fwcd · commit 7a0058a17a40 · 2021-06-10T16:38:43.000+02:00
diff --git a/Sources/SourceKitLSP/Swift/ExpressionTypeInfo.swift b/Sources/SourceKitLSP/Swift/ExpressionTypeInfo.swift
@@ -88,7 +88,7 @@ extension SwiftLanguageServer {
       skExpressionTypeInfos.forEach { (_, skExpressionTypeInfo) -> Bool in
         guard let info = ExpressionTypeInfo(skExpressionTypeInfo, in: snapshot) else {
           assert(false, "ExpressionTypeInfo failed to deserialize")
-          return false
+          return true
         }
         expressionTypeInfos.append(info)
         return true

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ extension SwiftLanguageServer {`
`88`	`88`	`skExpressionTypeInfos.forEach { (_, skExpressionTypeInfo) -> Bool in`
`89`	`89`	`guard let info = ExpressionTypeInfo(skExpressionTypeInfo, in: snapshot) else {`
`90`	`90`	`assert(false, "ExpressionTypeInfo failed to deserialize")`
`91`		`- return false`
	`91`	`+ return true`
`92`	`92`	`}`
`93`	`93`	`expressionTypeInfos.append(info)`
`94`	`94`	`return true`