Merge pull request #1362 from ahoppen/test-memory-leak

ahoppen · web-flow · commit 7a1324d2bb42 · 2024-05-29T08:06:21.000-07:00
diff --git a/Tests/SourceKitLSPTests/BackgroundIndexingTests.swift b/Tests/SourceKitLSPTests/BackgroundIndexingTests.swift
@@ -604,13 +604,14 @@ final class BackgroundIndexingTests: XCTestCase {
     )
 
     let receivedEmptyDiagnostics = self.expectation(description: "Received diagnostic refresh request")
+    receivedEmptyDiagnostics.assertForOverFulfill = false
     project.testClient.handleMultipleRequests { (_: CreateWorkDoneProgressRequest) in
       return VoidResponse()
     }
 
-    project.testClient.handleMultipleRequests { (_: DiagnosticsRefreshRequest) in
-      Task {
-        let updatedDiagnostics = try await project.testClient.send(
+    project.testClient.handleMultipleRequests { [weak project] (_: DiagnosticsRefreshRequest) in
+      Task { [weak project] in
+        let updatedDiagnostics = try await project?.testClient.send(
           DocumentDiagnosticsRequest(textDocument: TextDocumentIdentifier(uri))
         )
         guard case .full(let updatedDiagnostics) = updatedDiagnostics else {

Original file line number	Diff line number	Diff line change
`@@ -604,13 +604,14 @@ final class BackgroundIndexingTests: XCTestCase {`
`604`	`604`	`)`
`605`	`605`
`606`	`606`	`let receivedEmptyDiagnostics = self.expectation(description: "Received diagnostic refresh request")`
	`607`	`+ receivedEmptyDiagnostics.assertForOverFulfill = false`
`607`	`608`	`project.testClient.handleMultipleRequests { (_: CreateWorkDoneProgressRequest) in`
`608`	`609`	`return VoidResponse()`
`609`	`610`	`}`
`610`	`611`
`611`		`- project.testClient.handleMultipleRequests { (_: DiagnosticsRefreshRequest) in`
`612`		`- Task {`
`613`		`- let updatedDiagnostics = try await project.testClient.send(`
	`612`	`+ project.testClient.handleMultipleRequests { [weak project] (_: DiagnosticsRefreshRequest) in`
	`613`	`+ Task { [weak project] in`
	`614`	`+ let updatedDiagnostics = try await project?.testClient.send(`
`614`	`615`	`DocumentDiagnosticsRequest(textDocument: TextDocumentIdentifier(uri))`
`615`	`616`	`)`
`616`	`617`	`guard case .full(let updatedDiagnostics) = updatedDiagnostics else {`