Return after handling a CancelRequestNotification

ahoppen · ahoppen · commit 8c62fb5cd2ec · 2024-06-07T10:19:57.000-07:00
We were dispatching the notification to `messageHandlingQueue`, which then didn’t do anything with it. That’s not necessary.
diff --git a/Sources/SourceKitLSP/SourceKitLSPServer.swift b/Sources/SourceKitLSP/SourceKitLSPServer.swift
@@ -551,6 +551,7 @@ extension SourceKitLSPServer: MessageHandler {
         // are currently handling. Ordering is not important here. We thus don't
         // need to execute it on `messageHandlingQueue`.
         self.cancelRequest(params)
+        return
       }
 
       let signposter = Logger(subsystem: LoggingScope.subsystem, category: "message-handling")

Original file line number	Diff line number	Diff line change
`@@ -551,6 +551,7 @@ extension SourceKitLSPServer: MessageHandler {`
`551`	`551`	`// are currently handling. Ordering is not important here. We thus don't`
`552`	`552`	// need to execute it on `messageHandlingQueue`.
`553`	`553`	`self.cancelRequest(params)`
	`554`	`+ return`
`554`	`555`	`}`
`555`	`556`
`556`	`557`	`let signposter = Logger(subsystem: LoggingScope.subsystem, category: "message-handling")`