Merge pull request #1945 from bnbarham/revert-test-disable

bnbarham · web-flow · commit 94ba7ea20536 · 2025-02-11T14:39:50.000-08:00
Revert "Temporaily disable two crashing test cases"
diff --git a/Tests/SourceKitLSPTests/CodeActionTests.swift b/Tests/SourceKitLSPTests/CodeActionTests.swift
@@ -583,7 +583,6 @@ final class CodeActionTests: XCTestCase {
   }
 
   func testPackageManifestEditingCodeActionResult() async throws {
-    try XCTSkipIf(true, "Temporarily disable while investigating rdar://143336492")
     let testClient = try await TestSourceKitLSPClient(capabilities: clientCapabilitiesWithCodeActionSupport)
     let uri = DocumentURI(for: .swift)
     let positions = testClient.openDocument(
@@ -658,7 +657,6 @@ final class CodeActionTests: XCTestCase {
   }
 
   func testPackageManifestEditingCodeActionNoTestResult() async throws {
-    try XCTSkipIf(true, "Temporarily disable while investigating rdar://143336492")
     let testClient = try await TestSourceKitLSPClient(capabilities: clientCapabilitiesWithCodeActionSupport)
     let uri = DocumentURI(for: .swift)
     let positions = testClient.openDocument(

Original file line number	Diff line number	Diff line change
`@@ -583,7 +583,6 @@ final class CodeActionTests: XCTestCase {`
`583`	`583`	`}`
`584`	`584`
`585`	`585`	`func testPackageManifestEditingCodeActionResult() async throws {`
`586`		`- try XCTSkipIf(true, "Temporarily disable while investigating rdar://143336492")`
`587`	`586`	`let testClient = try await TestSourceKitLSPClient(capabilities: clientCapabilitiesWithCodeActionSupport)`
`588`	`587`	`let uri = DocumentURI(for: .swift)`
`589`	`588`	`let positions = testClient.openDocument(`
`@@ -658,7 +657,6 @@ final class CodeActionTests: XCTestCase {`
`658`	`657`	`}`
`659`	`658`
`660`	`659`	`func testPackageManifestEditingCodeActionNoTestResult() async throws {`
`661`		`- try XCTSkipIf(true, "Temporarily disable while investigating rdar://143336492")`
`662`	`660`	`let testClient = try await TestSourceKitLSPClient(capabilities: clientCapabilitiesWithCodeActionSupport)`
`663`	`661`	`let uri = DocumentURI(for: .swift)`
`664`	`662`	`let positions = testClient.openDocument(`