Make testImplicitCancellationOnEdit more robust

ahoppen · ahoppen · commit 9ceedcd19d0a · 2025-02-25T20:36:55.000-08:00
Instead of adding an arbitrary `Task.sleep` that should give us enough time to send the `textDocument/didChange` notification, wait until we receive the cancellation from the document change.
diff --git a/Tests/SourceKitLSPTests/SemanticTokensTests.swift b/Tests/SourceKitLSPTests/SemanticTokensTests.swift
@@ -897,8 +897,9 @@ final class SemanticTokensTests: XCTestCase {
     let testClient = try await TestSourceKitLSPClient(
       hooks: Hooks(preHandleRequest: { request in
         if request is DocumentSemanticTokensRequest {
-          // Sleep long enough for the edit to be handled
-          try? await Task.sleep(for: .seconds(10))
+          while !Task.isCancelled {
+            try? await Task.sleep(for: .seconds(1))
+          }
         }
       })
     )

Original file line number	Diff line number	Diff line change
`@@ -897,8 +897,9 @@ final class SemanticTokensTests: XCTestCase {`
`897`	`897`	`let testClient = try await TestSourceKitLSPClient(`
`898`	`898`	`hooks: Hooks(preHandleRequest: { request in`
`899`	`899`	`if request is DocumentSemanticTokensRequest {`
`900`		`- // Sleep long enough for the edit to be handled`
`901`		`- try? await Task.sleep(for: .seconds(10))`
	`900`	`+ while !Task.isCancelled {`
	`901`	`+ try? await Task.sleep(for: .seconds(1))`
	`902`	`+ }`
`902`	`903`	`}`
`903`	`904`	`})`
`904`	`905`	`)`