Finetune the wordings and logics

Author: joehsieh

Sources/SourceKitLSP/Swift/DiagnosticReportManager.swift

@@ -16,7 +16,7 @@ import SourceKitD
 import SwiftParserDiagnostics
 
 actor DiagnosticReportManager {
-  /// A task that gets report from sourcekitd
+  /// A task to produce diagnostics, either from a diagnostics request to `sourcektid` or by using the built-in swift-syntax.
   private typealias ReportTask = Task<RelatedFullDocumentDiagnosticReport, Error>
 
   private let sourcekitd: SourceKitD
@@ -60,8 +60,8 @@ actor DiagnosticReportManager {
     for snapshot: DocumentSnapshot,
     buildSettings: SwiftCompileCommand?
   ) async throws -> RelatedFullDocumentDiagnosticReport {
-    if let report = try await reportTask(for: snapshot.id, buildSettings: buildSettings)?.value {
-      return report
+    if let reportTask = reportTask(for: snapshot.id, buildSettings: buildSettings) {
+      return try await reportTask.value
     }
     let reportTask: Task<RelatedFullDocumentDiagnosticReport, Error>
     if let buildSettings, !buildSettings.isFallback {
@@ -70,7 +70,7 @@ actor DiagnosticReportManager {
       }
     } else {
       logger.log(
-        "Producing syntactic diagnostics from the built-in swift-syntax because we \(buildSettings != nil ? "have fallback build settings" : "don't have build settings")"
+        "Producing syntactic diagnostics from the built-in swift-syntax because we \(buildSettings != nil ? "have fallback build settings" : "don't have build settings", privacy: .public))"
       )
       // If we don't have build settings or we only have fallback build settings,
       // sourcekitd won't be able to give us accurate semantic diagnostics.