Fixed generated macro expansion file extension not recognised, by switching to file names which don't contain fragments

Author: lokesh-tr

Sources/SourceKitLSP/Swift/MacroExpansion.swift

@@ -88,19 +88,14 @@ extension SwiftLanguageService {
         )
       }
 
-      let macroExpansionFileName = sourceFileURL.lastPathComponent  // name of the source file
-      let macroExpansionPositionRangeFragment =
+      let macroExpansionFileName = sourceFileURL.deletingPathExtension().lastPathComponent  // name of the source file
+      let macroExpansionPositionRangeIndicator =
         "L\(macroEdit.range.lowerBound.line)C\(macroEdit.range.lowerBound.utf16index)-L\(macroEdit.range.upperBound.line)C\(macroEdit.range.upperBound.utf16index)"  // github permalink notation for position range
 
-      var macroExpansionFilePath = macroExpansionBufferDirectoryURL.appendingPathComponent(
-        "\(macroExpansionFileName)"
+      let macroExpansionFilePath = macroExpansionBufferDirectoryURL.appendingPathComponent(
+        "\(macroExpansionFileName)_\(macroExpansionPositionRangeIndicator).\(sourceFileURL.pathExtension)"
       )
 
-      var urlComponents = URLComponents(url: macroExpansionFilePath, resolvingAgainstBaseURL: false)
-      urlComponents?.fragment = macroExpansionPositionRangeFragment
-
-      macroExpansionFilePath = urlComponents?.url ?? macroExpansionFilePath
-
       let macroExpansionDocURI = DocumentURI(macroExpansionFilePath)
 
       do {

Tests/SourceKitLSPTests/ExecuteCommandTests.swift

@@ -248,12 +248,7 @@ final class ExecuteCommandTests: XCTestCase {
 
       XCTAssertEqual(
         url.lastPathComponent,
-        "MyMacroClient.swift",
-        "Failed for position range between \(positionMarker.start) and \(positionMarker.end)"
-      )
-      XCTAssertEqual(
-        url.fragment,
-        "L4C2-L4C19",
+        "MyMacroClient_L4C2-L4C19.swift",
         "Failed for position range between \(positionMarker.start) and \(positionMarker.end)"
       )
     }