SwiftLanguageServer: correct path detection on Windows

compnerd · compnerd · commit f670c423645d · 2021-05-25T12:42:59.000-07:00
Correct the polarity of the check.  The path being a UNC path or having a drive letter indicates that it *is* a path, as opposed to the inverted representation that was accidentally committed.
diff --git a/Sources/SourceKitLSP/Swift/SwiftLanguageServer.swift b/Sources/SourceKitLSP/Swift/SwiftLanguageServer.swift
@@ -1144,7 +1144,7 @@ extension SwiftLanguageServer: SKDNotificationHandler {
         // TODO: this is not completely portable, e.g. MacOS 9 HFS paths are
         // unhandled.
 #if os(Windows)
-        let isPath: Bool = !name.withCString(encodedAs: UTF16.self) {
+        let isPath: Bool = name.withCString(encodedAs: UTF16.self) {
           PathIsUNCW($0) || (0...25) ~= PathGetDriveNumberW($0)
         }
 #else

Original file line number	Diff line number	Diff line change
`@@ -1144,7 +1144,7 @@ extension SwiftLanguageServer: SKDNotificationHandler {`
`1144`	`1144`	`// TODO: this is not completely portable, e.g. MacOS 9 HFS paths are`
`1145`	`1145`	`// unhandled.`
`1146`	`1146`	`#if os(Windows)`
`1147`		`- let isPath: Bool = !name.withCString(encodedAs: UTF16.self) {`
	`1147`	`+ let isPath: Bool = name.withCString(encodedAs: UTF16.self) {`
`1148`	`1148`	`PathIsUNCW($0) \|\| (0...25) ~= PathGetDriveNumberW($0)`
`1149`	`1149`	`}`
`1150`	`1150`	`#else`