Fix decoding Array of LSPAnyCodable #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Dec 26, 2023
|
is |
|
Can we get this fixed? |
ahoppen
reviewed
Jan 8, 2024
Comment on lines
180
to
182
| if let value = value as? Element { | ||
| result.append(value) | ||
| } |
There was a problem hiding this comment.
Should we return nil if one of the elements can’t get decoded to indicate failure instead of silently dropping it?
There was a problem hiding this comment.
right, probably we should. Changed
Comment on lines
184
to
185
| // skip array of null | ||
| break |
There was a problem hiding this comment.
Shouldn’t we append nil to result if Element is Optional?
There was a problem hiding this comment.
the Element: LSPAnyCodable here is not optional
ahoppen
approved these changes
Jan 8, 2024
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes decoding array of LSPAnyCodable that wasn't handled properly and decoded only dictionary values