Log when the build graph starts being generated and when it finishes #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
approved these changes
May 24, 2024
hamishknight
approved these changes
May 24, 2024
ahoppen
force-pushed
the
generating-build-graph-logging
branch
from
6c74084 to
f0be6d6
Compare
|
@swift-ci Please test |
ahoppen
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…ild graph Rebuilding the build graph can take a while (initial loading of the build graph takes ~7s for sourcekit-lsp) and it’s good to show some progress during this time.
The signposts aren’t easily visible in the log (you need to add `--signpost` to `log show`) and don’t get logged on non-Darwin platforms at all. Add logging for it.
ahoppen
force-pushed
the
generating-build-graph-logging
branch
from
6067c88 to
dd67a3b
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
…he SourceKitLSPServer are modified `IndexProgressManager` iterates over all workspaces in the SourceKitLSPServer. Modifying workspaces might thus update the index progress status.
ahoppen
force-pushed
the
generating-build-graph-logging
branch
from
dd67a3b to
069e8a2
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signposts aren’t easily visible in the log (you need to add
--signposttolog show) and don’t get logged on non-Darwin platforms at all. Add logging for it.