Skip to content

Switch most tests to use background indexing instead of building the project #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 25, 2024

There are still a few tests left that explicitly check the before and after build state, which I didn’t modify.

rdar://128697501

@ahoppen ahoppen requested review from bnbarham and hamishknight May 25, 2024 19:02
@ahoppen ahoppen requested a review from benlangmuir as a code owner May 25, 2024 19:02
@ahoppen ahoppen force-pushed the switch-test-to-background-indexing branch 2 times, most recently from 63b50e3 to c00a3cf Compare May 25, 2024 19:11
@ahoppen
Copy link
Member Author

ahoppen commented May 25, 2024

@swift-ci Please test

@ahoppen ahoppen force-pushed the switch-test-to-background-indexing branch from c00a3cf to 16481df Compare May 27, 2024 01:57
@ahoppen
Copy link
Member Author

ahoppen commented May 27, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 27, 2024

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented May 27, 2024

@swift-ci Please test Windows

@ahoppen ahoppen changed the title Switch most tests to use background indexing instead of building the project 🚥 #1355 Switch most tests to use background indexing instead of building the project May 28, 2024
…project

There are still a few tests left that explicitly check the before and after build state, which I didn’t modify.

rdar://128697501
@ahoppen ahoppen force-pushed the switch-test-to-background-indexing branch from 16481df to 5e55203 Compare May 28, 2024 16:22
@ahoppen
Copy link
Member Author

ahoppen commented May 29, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 29, 2024

@swift-ci Please test macOS

@ahoppen ahoppen merged commit a6786cd into swiftlang:main May 30, 2024
3 checks passed
@ahoppen ahoppen deleted the switch-test-to-background-indexing branch May 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants