Forward all errors that translate to .cancelled from document diagnostics request
#1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostics request We were only forwarding `CancellationError` but depending on when cancellation happens, we would get `SKDError.cancelled`, which we would translate to empty diagnostics, causing the test to fail.
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 1, 2024
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only forwarding
CancellationErrorbut depending on when cancellation happens, we would getSKDError.cancelled, which we would translate to empty diagnostics, causing the test to fail.