Skip to content

Make passing --experimental-prepare-for-indexing to swift build an experimental feature #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 3, 2024

I’d like to qualify --experimental-prepare-for-indexing independently of background indexing using swift build. Because of this, I think there is value in using SourceKit-LSP using background indexing but without --experimental-prepare-for-indexing. It could also be useful to determine if bugs we may find are due to --experimental-prepare-for-indexing or also occur when running plain swift build commands.

@ahoppen ahoppen requested review from bnbarham and hamishknight June 3, 2024 22:21
@ahoppen ahoppen requested a review from benlangmuir as a code owner June 3, 2024 22:21
…n experimental feature

I’d like to qualify `--experimental-prepare-for-indexing` independently of background indexing using `swift build`. Because of this, I think there is value in using SourceKit-LSP using background indexing but without `--experimental-prepare-for-indexing`. It could also be useful to determine if bugs we may find are due to `--experimental-prepare-for-indexing` or also occur when running plain `swift build` commands.
@ahoppen ahoppen force-pushed the prepare-experimental-feature branch from 08ba877 to f98da77 Compare June 3, 2024 22:22
@ahoppen
Copy link
Member Author

ahoppen commented Jun 3, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jun 3, 2024

@swift-ci Please test Windows

@ahoppen ahoppen enabled auto-merge June 3, 2024 23:55
@ahoppen ahoppen merged commit b7fa9a9 into swiftlang:main Jun 4, 2024
3 checks passed
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants