Start migration of the communication between SourceKit-LSP and build systems to happen via the Build Server Protocol (BSP) #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
bsp-preparation
branch
2 times, most recently
from
389e34d to
0d6ab64
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
bsp-preparation
branch
from
0d6ab64 to
50328cc
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…n `BuildSystem` to a type that implements BSP
…anges to the build system
ahoppen
force-pushed
the
bsp-preparation
branch
from
50328cc to
b490a6f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
Merging this because I have a few BSP PRs stacked and want to make progress. I’ll address review comments in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in https://forums.swift.org/t/extending-functionality-of-build-server-protocol-with-sourcekit-lsp/74400, we want to switch the communication between SourceKit-LSP and build systems to happen via the Build Server Protocol (BSP).
This PR gets the transition started, making a few architectural adjustments and starts to migrate two messages to happen via BSP:
workspace/didChangeWatchedFiles(previouslyfilesDidChange) andbuildTarget/inverseSources(previouslyconfiguredTargets(for:)).Not all changes make terrible sense at this transitional stage. I should have marked all places that still need cleanup with
FIXME: (BSP migration). The expectation is that all of theseFIXMEcomments will be resolved by the end of the migration.Each commit in the PR is self-contained and can be reviewed individually.