Fix expected output in swift-format SkipUnless check
#2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren’t hitting this in Swift CI because we only test against Swift 6.2 toolchains, which take an earlier exit based on the Swift version.
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 14, 2025
| @@ -372,8 +372,8 @@ package actor SkipUnless { | |||
| let output = try result.utf8Output() | |||
| switch output { | |||
| case "": return false | |||
| case "let x = 1": return true | |||
| default: throw GenericError("Received unexpected formatting output: \(output)") | |||
| case "let x = 1\n": return true | |||
There was a problem hiding this comment.
🤷🏽 This check will disappear pretty quickly anyway once we no longer support building and testing SourceKit-LSP using a Swift 6.0 compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren’t hitting this in Swift CI because we only test against Swift 6.2 toolchains, which take an earlier exit based on the Swift version.