Skip to content

Fix expected output in swift-format SkipUnless check #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025
Merged

Fix expected output in swift-format SkipUnless check #2066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SKTestSupport/SkipUnless.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,8 @@ package actor SkipUnless {
let output = try result.utf8Output()
switch output {
case "": return false
case "let x = 1": return true
default: throw GenericError("Received unexpected formatting output: \(output)")
case "let x = 1\n": return true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just strip output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏽 This check will disappear pretty quickly anyway once we no longer support building and testing SourceKit-LSP using a Swift 6.0 compiler.

default: throw GenericError("Received unexpected formatting output: '\(output)'")
}
}
}
Expand Down