Fix setting permission on open for create to ugo+rw (+x if executable) which will then let umask adjust. (#86)

Author: daveinglis

Sources/SWBUtil/PbxCp.swift

@@ -298,7 +298,11 @@ fileprivate func copyRegular(_ srcPath: Path, _ srcParentPath: Path, _ dstPath:
 
 func _copyFile(_ srcPath: Path, _ dstPath: Path) throws {
     do {
-        let dstFd = try FileDescriptor.open(FilePath(dstPath.str), .writeOnly, options: [.create, .truncate], permissions: [.ownerReadWrite, .groupRead, .otherRead])
+        var permissions: FilePermissions = [.ownerRead, .ownerWrite, .groupRead, .groupWrite, .otherRead, .otherWrite]
+        if try localFS.isExecutable(srcPath) {
+            permissions.insert([.ownerExecute, .groupExecute, .otherExecute])
+        }
+        let dstFd = try FileDescriptor.open(FilePath(dstPath.str), .writeOnly, options: [.create, .truncate], permissions: permissions)
         try dstFd.closeAfter {
             let srcFd = try FileDescriptor.open(FilePath(srcPath.str), .readOnly)
             try srcFd.closeAfter {
@@ -316,7 +320,6 @@ func _copyFile(_ srcPath: Path, _ dstPath: Path) throws {
                     } while (bread > bwritten)
                 }
             }
-            try localFS.setFilePermissions(dstPath, permissions: localFS.getFilePermissions(srcPath))
         }
     } catch let error as Errno {
         throw POSIXError(error.rawValue, context: "copy", srcPath.str, dstPath.str)

Tests/SWBTaskExecutionTests/PBXCpTests.swift

@@ -426,7 +426,7 @@ fileprivate struct PBXCpTests: CoreBasedTests {
                 ))
                 let srcPerm = try fs.getFilePermissions(srcfile)
                 let dstPerm = try fs.getFilePermissions(dst.join(fwkName).join(fName))
-                #expect(srcPerm == dstPerm)
+                #expect(dstPerm == 0o755) // files are created with u+rw, g+wr, o+rw (and +x if src is executable) permissions and umask will adjust
             }
         }
     }
@@ -452,7 +452,7 @@ fileprivate struct PBXCpTests: CoreBasedTests {
                     size += try fd.writeAll(buffer1)
                 }
             }
-            try fs.setFilePermissions(sName, permissions: 0o777)
+            try fs.setFilePermissions(sName, permissions: 0o600)
 
             do {
                 let result = await pbxcp(["builtin-copy", "-V", src.str + Path.pathSeparatorString, dst.str], cwd: Path("/"))
@@ -463,7 +463,7 @@ fileprivate struct PBXCpTests: CoreBasedTests {
                 // Check permssions
                 let srcPerm = try fs.getFilePermissions(sName)
                 let dstPerm = try fs.getFilePermissions(dName)
-                #expect(srcPerm == dstPerm)
+                #expect(dstPerm == 0o644) // files are created with u+rw, g+wr, o+rw (and +x if src is executable) permissions and umask will adjust
                 #expect(FileManager.default.contentsEqual(atPath: sName.str, andPath: dName.str))
             }
         }