Don't crash in tests in CodeGenerationToolTests don't have a compile task, emit a test issue instead.

mhrawdon · mhrawdon · commit d397ecd533b5 · 2025-06-20T11:30:19.000-07:00
rdar://153135551
diff --git a/Tests/SWBBuildSystemTests/CodeGenerationToolTests.swift b/Tests/SWBBuildSystemTests/CodeGenerationToolTests.swift
@@ -176,7 +176,7 @@ fileprivate struct CodeGenerationToolTests: CoreBasedTests {
                         break
                     }
 
-                    let compileTask = compileTasks[0]
+                    let compileTask = try #require(compileTasks.first, "No compile task found for target '\(targetName)'.")
 
                     if targetName == "CoreFoo" {
                         #expect(results.getTasks(.matchRuleType("CompileC"), .matchRuleItemBasename("CoreFoo.m"), .matchTargetName(targetName)).count == 1)
@@ -432,7 +432,7 @@ fileprivate struct CodeGenerationToolTests: CoreBasedTests {
                         break
                     }
 
-                    let compileTask = compileTasks[0]
+                    let compileTask = try #require(compileTasks.first, "No compile task found for target '\(targetName)'.")
 
                     if targetName == "CoreFoo" {
                         #expect(results.getTasks(.matchRuleType("CompileC"), .matchRuleItemBasename("CoreFoo.m"), .matchTargetName(targetName)).count == 1)
@@ -642,7 +642,7 @@ fileprivate struct CodeGenerationToolTests: CoreBasedTests {
                         break
                     }
 
-                    let compileTask = compileTasks[0]
+                    let compileTask = try #require(compileTasks.first, "No compile task found for target '\(targetName)'.")
 
                     if targetName == "CoreFoo" {
                         #expect(results.getTasks(.matchRuleType("CompileC"), .matchRuleItemBasename("CoreFoo.m"), .matchTargetName(targetName)).count == 1)

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ fileprivate struct CodeGenerationToolTests: CoreBasedTests {`
`176`	`176`	`break`
`177`	`177`	`}`
`178`	`178`
`179`		`- let compileTask = compileTasks[0]`
	`179`	`+ let compileTask = try #require(compileTasks.first, "No compile task found for target '\(targetName)'.")`
`180`	`180`
`181`	`181`	`if targetName == "CoreFoo" {`
`182`	`182`	`#expect(results.getTasks(.matchRuleType("CompileC"), .matchRuleItemBasename("CoreFoo.m"), .matchTargetName(targetName)).count == 1)`
`@@ -432,7 +432,7 @@ fileprivate struct CodeGenerationToolTests: CoreBasedTests {`
`432`	`432`	`break`
`433`	`433`	`}`
`434`	`434`
`435`		`- let compileTask = compileTasks[0]`
	`435`	`+ let compileTask = try #require(compileTasks.first, "No compile task found for target '\(targetName)'.")`
`436`	`436`
`437`	`437`	`if targetName == "CoreFoo" {`
`438`	`438`	`#expect(results.getTasks(.matchRuleType("CompileC"), .matchRuleItemBasename("CoreFoo.m"), .matchTargetName(targetName)).count == 1)`
`@@ -642,7 +642,7 @@ fileprivate struct CodeGenerationToolTests: CoreBasedTests {`
`642`	`642`	`break`
`643`	`643`	`}`
`644`	`644`
`645`		`- let compileTask = compileTasks[0]`
	`645`	`+ let compileTask = try #require(compileTasks.first, "No compile task found for target '\(targetName)'.")`
`646`	`646`
`647`	`647`	`if targetName == "CoreFoo" {`
`648`	`648`	`#expect(results.getTasks(.matchRuleType("CompileC"), .matchRuleItemBasename("CoreFoo.m"), .matchTargetName(targetName)).count == 1)`