Skip to content

Commit 70d2b33

Browse files
committed
build: bulk set target properties
Avoid setting properties individually and set them in bulk. This avoids unnecessary property computation in CMake.
1 parent 8a28445 commit 70d2b33

File tree

2 files changed

+9
-19
lines changed

2 files changed

+9
-19
lines changed

extensions/CMakeLists.txt

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,17 @@ add_library(libcmark-gfm-extensions
1212
tasklist.c)
1313
target_compile_definitions(libcmark-gfm-extensions PUBLIC
1414
$<$<NOT:$<BOOL:${BUILD_SHARED_LIBS}>>:CMARK_GFM_STATIC_DEFINE>)
15-
15+
target_link_libraries(libcmark-gfm-extensions PRIVATE
16+
libcmark-gfm)
1617
set_target_properties(libcmark-gfm-extensions PROPERTIES
17-
OUTPUT_NAME "cmark-gfm-extensions"
18-
DEFINE_SYMBOL "libcmark_gfm_EXPORTS"
18+
DEFINE_SYMBOL libcmark_gfm_EXPORTS
19+
MACOSX_RPATH TRUE
20+
OUTPUT_NAME cmark-gfm-extensions
21+
PDB_NAME libcmark-gfm-extensions
1922
SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}.gfm.${PROJECT_VERSION_GFM}
2023
VERSION ${PROJECT_VERSION})
2124

22-
set_property(TARGET libcmark-gfm-extensions
23-
APPEND PROPERTY MACOSX_RPATH true)
24-
25-
# Avoid name clash between PROGRAM and LIBRARY pdb files.
26-
set_target_properties(libcmark-gfm-extensions PROPERTIES PDB_NAME cmark-gfm-extensions_dll)
27-
2825
list(APPEND CMARK_INSTALL libcmark-gfm-extensions)
29-
target_link_libraries(libcmark-gfm-extensions libcmark-gfm)
3026

3127

3228

src/CMakeLists.txt

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,19 +52,13 @@ target_include_directories(libcmark-gfm PUBLIC
5252
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/extensions/include>)
5353
target_link_libraries(libcmark-gfm PRIVATE
5454
$<$<BOOL:${THREADS_FOUND}>:Threads::Threads>)
55-
56-
# Include minor version and patch level in soname for now.
5755
set_target_properties(libcmark-gfm PROPERTIES
58-
OUTPUT_NAME "cmark-gfm"
56+
MACOSX_RPATH TRUE
57+
OUTPUT_NAME cmark-gfm
58+
PDB_NAME libcmark-gfm
5959
SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}.gfm.${PROJECT_VERSION_GFM}
6060
VERSION ${PROJECT_VERSION})
6161

62-
set_property(TARGET libcmark-gfm
63-
APPEND PROPERTY MACOSX_RPATH true)
64-
65-
# Avoid name clash between PROGRAM and LIBRARY pdb files.
66-
set_target_properties(libcmark-gfm PROPERTIES PDB_NAME cmark-gfm_dll)
67-
6862
list(APPEND CMARK_INSTALL libcmark-gfm)
6963

7064
install(TARGETS cmark-gfm ${CMARK_INSTALL}

0 commit comments

Comments
 (0)