[SR-9887] HTTPCookie on Linux does not accept Substring values

Author: saiHemak

Foundation/HTTPCookie.swift

@@ -255,10 +255,16 @@ open class HTTPCookie : NSObject {
     /// - Experiment: This is a draft API currently under consideration for official import into Foundation as a suitable alternative
     /// - Note: Since this API is under consideration it may be either removed or revised in the near future
     public init?(properties: [HTTPCookiePropertyKey : Any]) {
+        func  stringValue(strVal: Any?) -> String? {
+            if let subStr = strVal as? Substring {
+                return String(subStr)
+            }
+            return strVal as? String
+        }
         guard
-            let path = properties[.path] as? String,
-            let name = properties[.name] as? String,
-            let value = properties[.value] as? String
+            let path = stringValue(strVal: properties[.path]),
+            let name = stringValue(strVal: properties[.name]),
+            let value = stringValue(strVal: properties[.value])
         else {
             return nil
         }
@@ -659,4 +665,3 @@ fileprivate extension String {
         return self.replacingOccurrences(of: "&comma", with: ",")
     }
 }
-

TestFoundation/TestHTTPCookie.swift

@@ -19,6 +19,7 @@ class TestHTTPCookie: XCTestCase {
             ("test_cookiesWithResponseHeaderNoDomain", test_cookiesWithResponseHeaderNoDomain),
             ("test_cookiesWithResponseHeaderNoPathNoDomain", test_cookiesWithResponseHeaderNoPathNoDomain),
             ("test_cookieExpiresDateFormats", test_cookieExpiresDateFormats),
+            ("test_httpCookieWithSubstring", test_httpCookieWithSubstring),
         ]
     }
 
@@ -191,4 +192,13 @@ class TestHTTPCookie: XCTestCase {
             XCTAssertEqual(cookie.path, "/")
         }
     }
+
+    func test_httpCookieWithSubstring() {
+        let cookie = HTTPCookie(properties: [.domain: ".", .path: "/", .name: "davesy".dropLast(), .value: "Jonesy".dropLast()])
+        if let cookie = cookie {
+            XCTAssertEqual(cookie.name, "daves")
+        } else {
+            XCTFail("Unable to create cookie with substring")
+        }
+    }
 }