Merge pull request #2214 from pushkarnk/basic-auth-regression

[SR-10602]Don't fail a URLSessionTask on a 401 response

Author: millenomi

Foundation/URLSession/URLSessionTask.swift

@@ -579,11 +579,8 @@ extension _ProtocolClient : URLProtocolClient {
                                                                      sender: `protocol` as! _HTTPURLProtocol)
                 task.previousFailureCount += 1
                 urlProtocol(`protocol`, didReceive: authenticationChallenge)
-            } else {
-                let urlError = URLError(_nsError: NSError(domain: NSURLErrorDomain, code: NSURLErrorUserAuthenticationRequired, userInfo: nil))
-                urlProtocol(`protocol`, didFailWithError: urlError)
+                return
             }
-            return
         }
         switch session.behaviour(for: task) {
         case .taskDelegate(let delegate):

TestFoundation/TestURLSession.swift

@@ -795,9 +795,10 @@ class TestURLSession : LoopbackServerTest {
         let expect = expectation(description: "GET \(urlString): with a completion handler")
         var expectedResult = "unknown"
         let session = URLSession(configuration: URLSessionConfiguration.default)
-        let task = session.dataTask(with: url) { _, _, error in
+        let task = session.dataTask(with: url) { _, response, error in
             defer { expect.fulfill() }
-            XCTAssertNotNil(error)
+            XCTAssertNotNil(response)
+            XCTAssertNil(error)
         }
         task.resume()
         waitForExpectations(timeout: 12, handler: nil)