Skip to content

Commit 55bb988

Browse files
authored
Merge pull request #1432 from spevans/pr_countable_range
2 parents 8d4233c + a1871e5 commit 55bb988

File tree

4 files changed

+65
-70
lines changed

4 files changed

+65
-70
lines changed

Foundation/NSArray.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ open class NSArray : NSObject, NSCopying, NSMutableCopying, NSSecureCoding, NSCo
264264
return
265265
}
266266

267-
objects += range.toCountableRange()!.map { self[$0] }
267+
objects += Range(range)!.map { self[$0] }
268268
}
269269

270270
open func index(of anObject: Any) -> Int {
@@ -874,7 +874,7 @@ open class NSMutableArray : NSArray {
874874
if type(of: self) === NSMutableArray.self {
875875
_storage.removeSubrange(Range(range)!)
876876
} else {
877-
for idx in range.toCountableRange()!.reversed() {
877+
for idx in Range(range)!.reversed() {
878878
removeObject(at: idx)
879879
}
880880
}

Foundation/NSOrderedSet.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ extension NSOrderedSet {
312312
public convenience init(array set: [Any], range: NSRange, copyItems flag: Bool) {
313313
var objects = set
314314

315-
if let range = range.toCountableRange(), range.count != set.count || flag {
315+
if let range = Range(range), range.count != set.count || flag {
316316
objects = [Any]()
317317
for index in range.indices {
318318
let object = set[index]
@@ -461,7 +461,7 @@ extension NSMutableOrderedSet {
461461
}
462462

463463
open func replaceObjects(in range: NSRange, with objects: UnsafePointer<AnyObject>!, count: Int) {
464-
if let range = range.toCountableRange() {
464+
if let range = Range(range) {
465465
let buffer = UnsafeBufferPointer(start: objects, count: count)
466466
for (indexLocation, index) in range.indices.lazy.reversed().enumerated() {
467467
let object = buffer[indexLocation]
@@ -478,7 +478,7 @@ extension NSMutableOrderedSet {
478478
}
479479

480480
open func removeObjects(in range: NSRange) {
481-
if let range = range.toCountableRange() {
481+
if let range = Range(range) {
482482
for index in range.indices.lazy.reversed() {
483483
removeObject(at: index)
484484
}

Foundation/NSRange.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -353,11 +353,6 @@ extension NSRange {
353353
location = x.lowerBound
354354
length = x.count
355355
}
356-
357-
internal func toCountableRange() -> Range<Int>? {
358-
if location == NSNotFound { return nil }
359-
return location..<(location+length)
360-
}
361356
}
362357

363358
extension NSRange: NSSpecialValueCoding {

0 commit comments

Comments
 (0)