Set NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT when ENABLE_TESTING is set.

- Disable TestThread.test_threadName() as some of the tests are
  currently broken.

- Disable NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT on Windows as it
  exposes more broken tests at the moment.

Author: spevans

TestFoundation/CMakeLists.txt

@@ -116,6 +116,12 @@ target_link_libraries(TestFoundation PRIVATE
 target_link_libraries(TestFoundation PRIVATE
   XCTest)
 
+# TODO: When all the normal tests run on Windows remove this gate to fix some more
+if(ENABLE_TESTING AND NOT CMAKE_SYSTEM_NAME STREQUAL Windows)
+  target_compile_definitions(TestFoundation PRIVATE
+    NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT)
+endif()
+
 # NOTE(compnerd) create a test "app" directory as we need the xdgTestHelper as
 # an executable peer and the binary will be placed in the directory with the
 # same name as a peer in the build tree.

TestFoundation/TestObjCRuntime.swift

@@ -64,7 +64,7 @@ class TestObjCRuntime: XCTestCase {
     #if NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT
     func testClassesRenamedByAPINotes() throws {
         for entry in _NSClassesRenamedByObjCAPINotes {
-            XCTAssert(NSClassFromString(NSStringFromClass(entry.class)) === entry.class)
+            XCTAssert(try XCTUnwrap(NSClassFromString(NSStringFromClass(entry.class))) === entry.class)
             XCTAssert(NSStringFromClass(try XCTUnwrap(NSClassFromString(entry.objCName))) == entry.objCName)
         }
     }

TestFoundation/TestThread.swift

@@ -31,7 +31,7 @@ class TestThread : XCTestCase {
             ("test_sleepUntilDate", test_sleepUntilDate),
         ]
 
-#if NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT
+#if NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT && false // Disable for now as some tests are broken
         tests.append(contentsOf: [
             ("test_threadName", test_threadName),
         ])