Always Handle Broken Pipes on Windows

gmittert · gmittert · commit 64aa5e3a2918 · 2019-06-27T14:53:13.000-07:00
Getting an ERROR_BROKEN_PIPE shouldn't be an error in any case, not just
when we're reading untilEOF.
diff --git a/Foundation/FileHandle.swift b/Foundation/FileHandle.swift
@@ -267,7 +267,7 @@ open class FileHandle : NSObject {
           var BytesRead: DWORD = 0
           if !ReadFile(_handle, buffer.advanced(by: total), BytesToRead, &BytesRead, nil) {
             let err = GetLastError()
-            if err == ERROR_BROKEN_PIPE && untilEOF {
+            if err == ERROR_BROKEN_PIPE {
                 break
             }
             free(buffer)

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ open class FileHandle : NSObject {`
`267`	`267`	`var BytesRead: DWORD = 0`
`268`	`268`	`if !ReadFile(_handle, buffer.advanced(by: total), BytesToRead, &BytesRead, nil) {`
`269`	`269`	`let err = GetLastError()`
`270`		`- if err == ERROR_BROKEN_PIPE && untilEOF {`
	`270`	`+ if err == ERROR_BROKEN_PIPE {`
`271`	`271`	`break`
`272`	`272`	`}`
`273`	`273`	`free(buffer)`