Skip to content

Commit 75ba271

Browse files
authored
Merge pull request #770 from ikesyo/returning-dispatchqueue-sync
2 parents 0e9f1e6 + bb20f62 commit 75ba271

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

Foundation/NSURLSession/NSURLSessionTask.swift

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -140,19 +140,15 @@ open class URLSessionTask : NSObject, NSCopying {
140140
/// May differ from originalRequest due to http server redirection
141141
/*@NSCopying*/ open fileprivate(set) var currentRequest: URLRequest? {
142142
get {
143-
var r: URLRequest? = nil
144-
taskAttributesIsolation.sync { r = self._currentRequest }
145-
return r
143+
return taskAttributesIsolation.sync { self._currentRequest }
146144
}
147145
//TODO: dispatch_barrier_async
148146
set { taskAttributesIsolation.async(flags: .barrier) { self._currentRequest = newValue } }
149147
}
150148
fileprivate var _currentRequest: URLRequest? = nil
151149
/*@NSCopying*/ open fileprivate(set) var response: URLResponse? {
152150
get {
153-
var r: URLResponse? = nil
154-
taskAttributesIsolation.sync { r = self._response }
155-
return r
151+
return taskAttributesIsolation.sync { self._response }
156152
}
157153
set { taskAttributesIsolation.async(flags: .barrier) { self._response = newValue } }
158154
}
@@ -166,9 +162,7 @@ open class URLSessionTask : NSObject, NSCopying {
166162
/// Number of body bytes already received
167163
open fileprivate(set) var countOfBytesReceived: Int64 {
168164
get {
169-
var r: Int64 = 0
170-
taskAttributesIsolation.sync { r = self._countOfBytesReceived }
171-
return r
165+
return taskAttributesIsolation.sync { self._countOfBytesReceived }
172166
}
173167
set { taskAttributesIsolation.async(flags: .barrier) { self._countOfBytesReceived = newValue } }
174168
}
@@ -177,9 +171,7 @@ open class URLSessionTask : NSObject, NSCopying {
177171
/// Number of body bytes already sent */
178172
open fileprivate(set) var countOfBytesSent: Int64 {
179173
get {
180-
var r: Int64 = 0
181-
taskAttributesIsolation.sync { r = self._countOfBytesSent }
182-
return r
174+
return taskAttributesIsolation.sync { self._countOfBytesSent }
183175
}
184176
set { taskAttributesIsolation.async(flags: .barrier) { self._countOfBytesSent = newValue } }
185177
}
@@ -209,9 +201,7 @@ open class URLSessionTask : NSObject, NSCopying {
209201
*/
210202
open var state: URLSessionTask.State {
211203
get {
212-
var r: URLSessionTask.State = .suspended
213-
taskAttributesIsolation.sync { r = self._state }
214-
return r
204+
return taskAttributesIsolation.sync { self._state }
215205
}
216206
set { taskAttributesIsolation.async(flags: .barrier) { self._state = newValue } }
217207
}
@@ -296,9 +286,7 @@ open class URLSessionTask : NSObject, NSCopying {
296286
/// URLSessionTask.highPriority, but use is not restricted to these.
297287
open var priority: Float {
298288
get {
299-
var r: Float = 0
300-
taskAttributesIsolation.sync { r = self._priority }
301-
return r
289+
return taskAttributesIsolation.sync { self._priority }
302290
}
303291
set {
304292
taskAttributesIsolation.async(flags: .barrier) { self._priority = newValue }

0 commit comments

Comments
 (0)