[SR-9979] FileHandle class used to implement FileManager._compareFiles

Author: karthikkeyan

Foundation/FileManager.swift

@@ -1720,39 +1720,31 @@ open class FileManager : NSObject {
 #if os(Windows)
         NSUnimplemented()
 #else
-        let fd1 = open(file1Rep, O_RDONLY)
-        guard fd1 >= 0 else {
+        guard let file1 = FileHandle(forReadingAtPath: String(cString: file1Rep)) else {
             return false
         }
-        defer { close(fd1) }
-
-        let fd2 = open(file2Rep, O_RDONLY)
-        guard fd2 >= 0 else {
+        
+        defer { try? file1.close() }
+        
+        guard let file2 = FileHandle(forReadingAtPath: String(cString: file2Rep)) else {
             return false
         }
-        defer { close(fd2) }
-
-        let buffer1 = UnsafeMutablePointer<UInt8>.allocate(capacity: bufSize)
-        let buffer2 = UnsafeMutablePointer<UInt8>.allocate(capacity: bufSize)
-        defer {
-            buffer1.deallocate()
-            buffer2.deallocate()
-        }
-
+        
+        defer { try? file2.close() }
+        
         var bytesLeft = size
         while bytesLeft > 0 {
             let bytesToRead = Int(min(Int64(bufSize), bytesLeft))
-            guard read(fd1, buffer1, bytesToRead) == bytesToRead else {
-                return false
-            }
-            guard read(fd2, buffer2, bytesToRead) == bytesToRead else {
-                return false
-            }
-            guard memcmp(buffer1, buffer2, bytesToRead) == 0 else {
+            let file1Data = file1.readData(ofLength: bytesToRead)
+            let file2Data = file2.readData(ofLength: bytesToRead)
+            
+            guard file1Data.count == bytesToRead, file2Data.count == bytesToRead, file1Data == file2Data else {
                 return false
             }
+            
             bytesLeft -= Int64(bytesToRead)
         }
+        
         return true
 #endif
     }