[millenomi] Constant strings must be correctly memory-managed in SCF.

millenomi · millenomi · commit 7ccc582fb4b8 · 2020-08-26T14:45:21.000-07:00
diff --git a/CoreFoundation/URL.subproj/CFURLComponents.c b/CoreFoundation/URL.subproj/CFURLComponents.c
@@ -1285,7 +1285,7 @@ static CFArrayRef _CFURLComponentsCopyQueryItemsInternal(CFURLComponentsRef comp
                             }
                         }
                         else {
-                            nameString =  CFSTR("");
+                            nameString = CFRetain(CFSTR(""));
                         }
                         CFTypeRef keys[] = {_kCFURLComponentsNameKey};
                         CFTypeRef values[] = {nameString};
@@ -1346,7 +1346,7 @@ static CFArrayRef _CFURLComponentsCopyQueryItemsInternal(CFURLComponentsRef comp
                     }
                 }
                 else {
-                    nameString =  CFSTR("");
+                    nameString = CFRetain(CFSTR(""));
                 }
                 CFTypeRef keys[] = {_kCFURLComponentsNameKey};
                 CFTypeRef values[] = {nameString};

Original file line number	Diff line number	Diff line change
`@@ -1285,7 +1285,7 @@ static CFArrayRef _CFURLComponentsCopyQueryItemsInternal(CFURLComponentsRef comp`
`1285`	`1285`	`}`
`1286`	`1286`	`}`
`1287`	`1287`	`else {`
`1288`		`- nameString = CFSTR("");`
	`1288`	`+ nameString = CFRetain(CFSTR(""));`
`1289`	`1289`	`}`
`1290`	`1290`	`CFTypeRef keys[] = {_kCFURLComponentsNameKey};`
`1291`	`1291`	`CFTypeRef values[] = {nameString};`
`@@ -1346,7 +1346,7 @@ static CFArrayRef _CFURLComponentsCopyQueryItemsInternal(CFURLComponentsRef comp`
`1346`	`1346`	`}`
`1347`	`1347`	`}`
`1348`	`1348`	`else {`
`1349`		`- nameString = CFSTR("");`
	`1349`	`+ nameString = CFRetain(CFSTR(""));`
`1350`	`1350`	`}`
`1351`	`1351`	`CFTypeRef keys[] = {_kCFURLComponentsNameKey};`
`1352`	`1352`	`CFTypeRef values[] = {nameString};`