Foundation: fix invalid free

compnerd · compnerd · commit 8efa65242bae · 2020-02-14T18:57:28.000Z
The memory in the `String` is not-being copied, and thus is more of a
view into the memory, not an owning reference.  Do not free this memory
after the destruction of the object.
diff --git a/Foundation/NSData.swift b/Foundation/NSData.swift
@@ -602,7 +602,7 @@ open class NSData : NSObject, NSCopying, NSMutableCopying, NSSecureCoding {
         let buffer = UnsafeMutableRawBufferPointer(start: ptr, count: capacity)
         let length = NSData.base64EncodeBytes(self, options: options, buffer: buffer)
 
-        return String(bytesNoCopy: ptr, length: length, encoding: .ascii, freeWhenDone: true)!
+        return String(bytesNoCopy: ptr, length: length, encoding: .ascii, freeWhenDone: false)!
     }
 
     /// Creates a Base64, UTF-8 encoded Data from the data object using the given options.

Original file line number	Diff line number	Diff line change
`@@ -602,7 +602,7 @@ open class NSData : NSObject, NSCopying, NSMutableCopying, NSSecureCoding {`
`602`	`602`	`let buffer = UnsafeMutableRawBufferPointer(start: ptr, count: capacity)`
`603`	`603`	`let length = NSData.base64EncodeBytes(self, options: options, buffer: buffer)`
`604`	`604`
`605`		`- return String(bytesNoCopy: ptr, length: length, encoding: .ascii, freeWhenDone: true)!`
	`605`	`+ return String(bytesNoCopy: ptr, length: length, encoding: .ascii, freeWhenDone: false)!`
`606`	`606`	`}`
`607`	`607`
`608`	`608`	`/// Creates a Base64, UTF-8 encoded Data from the data object using the given options.`