Merge pull request #2267 from compnerd/dead-pipes-tell-no-secrets

compnerd · web-flow · commit 999cbc80031d · 2019-05-15T13:25:41.000-07:00
Foundation: fix `Process.run()` handle handling for Windows
diff --git a/Foundation/Process.swift b/Foundation/Process.swift
@@ -519,15 +519,12 @@ open class Process: NSObject {
 
         if let pipe = standardInput as? Pipe {
           pipe.fileHandleForReading.closeFile()
-          pipe.fileHandleForWriting.closeFile()
         }
         if let pipe = standardOutput as? Pipe {
-          pipe.fileHandleForReading.closeFile()
           pipe.fileHandleForWriting.closeFile()
         }
         if let pipe = standardError as? Pipe {
           pipe.fileHandleForWriting.closeFile()
-          pipe.fileHandleForReading.closeFile()
         }
 
         self.runLoop = RunLoop.current

Original file line number	Diff line number	Diff line change
`@@ -519,15 +519,12 @@ open class Process: NSObject {`
`519`	`519`
`520`	`520`	`if let pipe = standardInput as? Pipe {`
`521`	`521`	`pipe.fileHandleForReading.closeFile()`
`522`		`- pipe.fileHandleForWriting.closeFile()`
`523`	`522`	`}`
`524`	`523`	`if let pipe = standardOutput as? Pipe {`
`525`		`- pipe.fileHandleForReading.closeFile()`
`526`	`524`	`pipe.fileHandleForWriting.closeFile()`
`527`	`525`	`}`
`528`	`526`	`if let pipe = standardError as? Pipe {`
`529`	`527`	`pipe.fileHandleForWriting.closeFile()`
`530`		`- pipe.fileHandleForReading.closeFile()`
`531`	`528`	`}`
`532`	`529`
`533`	`530`	`self.runLoop = RunLoop.current`