[Windows] Now FileManager.isExecutableFile(atPath:) checks if the file exists and is readable

pvieito · web-flow · commit 9cd3a53915ae · 2019-04-18T00:00:03.000+02:00
diff --git a/Foundation/FileManager+Win32.swift b/Foundation/FileManager+Win32.swift
@@ -497,8 +497,9 @@ extension FileManager {
     }
 
     internal func _isExecutableFile(atPath path: String) -> Bool {
-        // FIXME(compnerd) is there some test that we can perform here?
-        return true
+        var isDirectory: ObjCBool = false
+        guard fileExists(atPath: path, isDirectory: &isDirectory) else { return false }
+        return !isDirectory.boolValue && _isReadableFile(atPath: path)
     }
 
     internal func _isDeletableFile(atPath path: String) -> Bool {

Original file line number	Diff line number	Diff line change
`@@ -497,8 +497,9 @@ extension FileManager {`
`497`	`497`	`}`
`498`	`498`
`499`	`499`	`internal func _isExecutableFile(atPath path: String) -> Bool {`
`500`		`- // FIXME(compnerd) is there some test that we can perform here?`
`501`		`- return true`
	`500`	`+ var isDirectory: ObjCBool = false`
	`501`	`+ guard fileExists(atPath: path, isDirectory: &isDirectory) else { return false }`
	`502`	`+ return !isDirectory.boolValue && _isReadableFile(atPath: path)`
`502`	`503`	`}`
`503`	`504`
`504`	`505`	`internal func _isDeletableFile(atPath path: String) -> Bool {`