The endDocument callback was never called.

Fixed by signaling the final ("terminal") chunk to SAX.

Author: dhoepfl

CoreFoundation/Parsing.subproj/CFXMLInterface.c

@@ -1,14 +1,14 @@
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2014 - 2015 Apple Inc. and the Swift project authors
+// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See http://swift.org/LICENSE.txt for license information
 // See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 //
 
 /*	CFXMLInterface.c
-	Copyright (c) 2015 Apple Inc. and the Swift project authors
+	Copyright (c) 2020 Apple Inc. and the Swift project authors
  */
 
 #include <CoreFoundation/CFRuntime.h>
@@ -210,7 +210,8 @@ void _CFXMLInterfaceCtxtUseOptions(_CFXMLInterfaceParserContext ctx, CFIndex opt
 }
 
 int _CFXMLInterfaceParseChunk(_CFXMLInterfaceParserContext ctxt, const char *chunk, int size, int terminate) {
-    return xmlParseChunk(ctxt, chunk, size, terminate);
+    int ret = xmlParseChunk(ctxt, chunk, size, terminate);
+    return ret == XML_ERR_DOCUMENT_END && terminate ? XML_ERR_OK : ret;
 }
 
 void _CFXMLInterfaceStopParser(_CFXMLInterfaceParserContext ctx) {

Sources/FoundationXML/XMLParser.swift

@@ -486,8 +486,9 @@ open class XMLParser : NSObject {
         return false
     }
 
-    internal func parseData(_ data: Data) -> Bool {
+    internal func parseData(_ data: Data, lastChunkOfData: Bool = false) -> Bool {
         _CFXMLInterfaceSetStructuredErrorFunc(interface, _structuredErrorFunc)
+        defer { _CFXMLInterfaceSetStructuredErrorFunc(interface, nil) }
 
         let handler: _CFXMLInterfaceSAXHandler? = (delegate != nil ? _handler : nil)
         let unparsedData: Data
@@ -538,11 +539,10 @@ open class XMLParser : NSObject {
 
         let parseResult = unparsedData.withUnsafeBytes { (rawBuffer: UnsafeRawBufferPointer) -> Int32 in
             let bytes = rawBuffer.baseAddress!.assumingMemoryBound(to: CChar.self)
-            return _CFXMLInterfaceParseChunk(_parserContext, bytes, Int32(unparsedData.count), 0)
+            return _CFXMLInterfaceParseChunk(_parserContext, bytes, Int32(unparsedData.count), lastChunkOfData ? 1 : 0)
         }
 
         let result = _handleParseResult(parseResult)
-        _CFXMLInterfaceSetStructuredErrorFunc(interface, nil)
         return result
     }
 
@@ -560,6 +560,7 @@ open class XMLParser : NSObject {
                 let data = Data(bytesNoCopy: buffer, count: len, deallocator: .none)
                 result = parseData(data)
             case 0:
+                result = parseData(Data(), lastChunkOfData: true)
                 break parseLoop
             default: // See SR-13516, should be `case ..<0:`
                 result = false
@@ -582,7 +583,7 @@ open class XMLParser : NSObject {
         if _stream != nil {
             return parseFrom(_stream!)
         } else if _data != nil {
-            return parseData(_data!)
+            return parseData(_data!, lastChunkOfData: true)
         }
 
         return false

Tests/Foundation/Tests/TestXMLParser.swift

@@ -95,6 +95,7 @@ class TestXMLParser : XCTestCase {
             .foundCharacters("bar"),
             .didEndElement("foo", uri, namespaces ? "foo" : nil),
             .didEndElement("test", uri, namespaces ? "test" : nil),
+            .endDocument,
         ]
     }