Merge pull request #2097 from millenomi/nskeyedarchiver-no-openstep

millenomi · web-flow · commit a06922a06566 · 2019-04-12T09:31:13.000-07:00
Parity: NSKeyedArchiver: Consider response to setting an output format other than .xml or .binary
diff --git a/Foundation/NSKeyedArchiver.swift b/Foundation/NSKeyedArchiver.swift
@@ -99,9 +99,8 @@ open class NSKeyedArchiver : NSCoder {
     /// The available formats are `xml` and `binary`.
     open var outputFormat = PropertyListSerialization.PropertyListFormat.binary {
         willSet {
-            if outputFormat != .xml &&
-                outputFormat != .binary {
-                NSUnimplemented()
+            guard (newValue == .xml || newValue == .binary) else {
+                fatalError("Unsupported format: \(newValue)")
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,8 @@ open class NSKeyedArchiver : NSCoder {`
`99`	`99`	/// The available formats are `xml` and `binary`.
`100`	`100`	`open var outputFormat = PropertyListSerialization.PropertyListFormat.binary {`
`101`	`101`	`willSet {`
`102`		`- if outputFormat != .xml &&`
`103`		`- outputFormat != .binary {`
`104`		`- NSUnimplemented()`
	`102`	`+ guard (newValue == .xml \|\| newValue == .binary) else {`
	`103`	`+ fatalError("Unsupported format: \(newValue)")`
`105`	`104`	`}`
`106`	`105`	`}`
`107`	`106`	`}`