Foundation: allow failure in attribute query

compnerd · compnerd · commit a3f5cc03e920 · 2019-04-29T13:20:40.000-07:00
The path being removed may not exist.  Permit the `attributes(of:)` to
fail and propagate the exception.
diff --git a/Foundation/FileManager+Win32.swift b/Foundation/FileManager+Win32.swift
@@ -406,7 +406,7 @@ extension FileManager {
         guard alreadyConfirmed || shouldRemoveItemAtPath(path, isURL: isURL) else {
             return
         }
-        let faAttributes = try! windowsFileAttributes(atPath: path)
+        let faAttributes = try windowsFileAttributes(atPath: path)
         if faAttributes.dwFileAttributes & DWORD(FILE_ATTRIBUTE_DIRECTORY) == 0 {
             if !path.withCString(encodedAs: UTF16.self, DeleteFileW) {
                 throw _NSErrorWithWindowsError(GetLastError(), reading: false)

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ extension FileManager {`
`406`	`406`	`guard alreadyConfirmed \|\| shouldRemoveItemAtPath(path, isURL: isURL) else {`
`407`	`407`	`return`
`408`	`408`	`}`
`409`		`- let faAttributes = try! windowsFileAttributes(atPath: path)`
	`409`	`+ let faAttributes = try windowsFileAttributes(atPath: path)`
`410`	`410`	`if faAttributes.dwFileAttributes & DWORD(FILE_ATTRIBUTE_DIRECTORY) == 0 {`
`411`	`411`	`if !path.withCString(encodedAs: UTF16.self, DeleteFileW) {`
`412`	`412`	`throw _NSErrorWithWindowsError(GetLastError(), reading: false)`