URLSessionTask retain cycle and memory leak fix

johnno1962 · johnno1962 · commit a6ac40a9e5b7 · 2017-08-30T21:53:56.000+01:00
diff --git a/Foundation/URLSession/URLSessionTask.swift b/Foundation/URLSession/URLSessionTask.swift
@@ -547,6 +547,7 @@ extension _ProtocolClient : URLProtocolClient {
                 session.taskRegistry.remove(task)
             }
         }
+        task._protocol = nil
     }
 
     func urlProtocol(_ protocol: URLProtocol, didCancel challenge: URLAuthenticationChallenge) {
@@ -602,6 +603,7 @@ extension _ProtocolClient : URLProtocolClient {
                 session.taskRegistry.remove(task)
             }
         }
+        task._protocol = nil
     }
 
     func urlProtocol(_ protocol: URLProtocol, cachedResponseIsValid cachedResponse: CachedURLResponse) {

Original file line number	Diff line number	Diff line change
`@@ -547,6 +547,7 @@ extension _ProtocolClient : URLProtocolClient {`
`547`	`547`	`session.taskRegistry.remove(task)`
`548`	`548`	`}`
`549`	`549`	`}`
	`550`	`+ task._protocol = nil`
`550`	`551`	`}`
`551`	`552`
`552`	`553`	`func urlProtocol(_ protocol: URLProtocol, didCancel challenge: URLAuthenticationChallenge) {`
`@@ -602,6 +603,7 @@ extension _ProtocolClient : URLProtocolClient {`
`602`	`603`	`session.taskRegistry.remove(task)`
`603`	`604`	`}`
`604`	`605`	`}`
	`606`	`+ task._protocol = nil`
`605`	`607`	`}`
`606`	`608`
`607`	`609`	`func urlProtocol(_ protocol: URLProtocol, cachedResponseIsValid cachedResponse: CachedURLResponse) {`