[Foundation] PersonNameComponents: Modernize hashing

Author: lorentey

Darwin/Foundation-swiftoverlay-Tests/TestPersonNameComponents.swift

@@ -29,6 +29,34 @@ class TestPersonNameComponents : TestPersonNameComponentsSuper {
         result.familyName = familyName
         return result
     }
+
+    func test_Hashing() {
+        guard #available(macOS 10.11, iOS 9.0, *) else { return }
+
+        let values: [[PersonNameComponents]] = [
+            [
+                makePersonNameComponents(givenName: "Kevin", familyName: "Frank"),
+                makePersonNameComponents(givenName: "Kevin", familyName: "Frank"),
+            ],
+            [
+                makePersonNameComponents(givenName: "John", familyName: "Frank"),
+                makePersonNameComponents(givenName: "John", familyName: "Frank"),
+            ],
+            [
+                makePersonNameComponents(givenName: "Kevin", familyName: "Appleseed"),
+                makePersonNameComponents(givenName: "Kevin", familyName: "Appleseed"),
+            ],
+            [
+                makePersonNameComponents(givenName: "John", familyName: "Appleseed"),
+                makePersonNameComponents(givenName: "John", familyName: "Appleseed"),
+            ]
+        ]
+        checkHashableGroups(
+            values,
+            // FIXME: PersonNameComponents hashes aren't seeded.
+            allowIncompleteHashing: true)
+    }
+
     func test_AnyHashableContainingPersonNameComponents() {
         if #available(OSX 10.11, iOS 9.0, *) {
             let values: [PersonNameComponents] = [
@@ -72,6 +100,7 @@ class TestPersonNameComponents : TestPersonNameComponentsSuper {
 
 #if !FOUNDATION_XCTEST
 var PersonNameComponentsTests = TestSuite("TestPersonNameComponents")
+PersonNameComponentsTests.test("test_Hashing") { TestPersonNameComponents().test_Hashing() }
 PersonNameComponentsTests.test("test_AnyHashableContainingPersonNameComponents") { TestPersonNameComponents().test_AnyHashableContainingPersonNameComponents() }
 PersonNameComponentsTests.test("test_AnyHashableCreatedFromNSPersonNameComponents") { TestPersonNameComponents().test_AnyHashableCreatedFromNSPersonNameComponents() }
 runAllTests()

Darwin/Foundation-swiftoverlay/PersonNameComponents.swift

@@ -71,10 +71,10 @@ public struct PersonNameComponents : ReferenceConvertible, Hashable, Equatable,
         set { _applyMutation { $0.phoneticRepresentation = newValue } }
     }
 
-    public var hashValue : Int {
-        return _handle.map { $0.hash }
+    public func hash(into hasher: inout Hasher) {
+        hasher.combine(_handle._uncopiedReference())
     }
-    
+
     @available(macOS 10.11, iOS 9.0, *)
     public static func ==(lhs : PersonNameComponents, rhs: PersonNameComponents) -> Bool {
         // Don't copy references here; no one should be storing anything