Merge pull request #2263 from compnerd/i-have-made-a-grave-error

Improve Windows error handling

Author: compnerd

Foundation/FileHandle.swift

@@ -378,10 +378,10 @@ open class FileHandle : NSObject {
         while bytesRemaining > 0 {
             var bytesWritten: DWORD = 0
             if !WriteFile(handle, buf.advanced(by: length - bytesRemaining), DWORD(bytesRemaining), &bytesWritten, nil) {
-                throw _NSErrorWithErrno(Int32(GetLastError()), reading: false, path: nil)
+                throw _NSErrorWithWindowsError(GetLastError(), reading: false)
             }
             if bytesWritten == 0 {
-                throw _NSErrorWithErrno(Int32(GetLastError()), reading: false, path: nil)
+                throw _NSErrorWithWindowsError(GetLastError(), reading: false)
             }
             bytesRemaining -= Int(bytesWritten)
         }

Foundation/Process.swift

@@ -503,15 +503,15 @@ open class Process: NSObject {
                                  DWORD(CREATE_UNICODE_ENVIRONMENT), UnsafeMutableRawPointer(mutating: wszEnvironment),
                                  wszCurrentDirectory,
                                  &siStartupInfo, &piProcessInfo) {
-                throw NSError(domain: _NSWindowsErrorDomain, code: Int(GetLastError()))
+                throw _NSErrorWithWindowsError(GetLastError(), reading: false)
               }
             }
           }
         }
 
         self.processHandle = piProcessInfo.hProcess
         if !CloseHandle(piProcessInfo.hThread) {
-          throw NSError(domain: _NSWindowsErrorDomain, code: Int(GetLastError()))
+          throw _NSErrorWithWindowsError(GetLastError(), reading: false)
         }
 
         if let pipe = standardInput as? Pipe {