Skip to content

Commit d602c57

Browse files
authored
Merge pull request #2480 from millenomi/xmldtd-init
Parity: XMLDTD.init()
2 parents a7e588f + a6eccbe commit d602c57

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

Foundation/XMLDTD.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ open class XMLDTD : XMLNode {
2626
}
2727

2828
public init() {
29-
NSUnimplemented()
29+
super.init(kind: .DTDKind, options: [])
3030
}
3131

3232
public convenience init(contentsOf url: URL, options mask: XMLNode.Options = []) throws {

TestFoundation/TestXMLDocument.swift

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -674,6 +674,17 @@ class TestXMLDocument : LoopbackServerTest {
674674
_ = XMLNode()
675675
}
676676

677+
func test_creatingAnEmptyDTD() {
678+
let dtd = XMLDTD()
679+
XCTAssertEqual(dtd.publicID, "")
680+
XCTAssertEqual(dtd.systemID, "")
681+
XCTAssertEqual(dtd.children ?? [], [])
682+
683+
let plistDTDUrl = "https://www.apple.com/DTDs/PropertyList-1.0.dtd"
684+
dtd.systemID = plistDTDUrl
685+
XCTAssertEqual(dtd.systemID, plistDTDUrl)
686+
}
687+
677688
static var allTests: [(String, (TestXMLDocument) -> () throws -> Void)] {
678689
return [
679690
("test_basicCreation", test_basicCreation),
@@ -707,6 +718,7 @@ class TestXMLDocument : LoopbackServerTest {
707718
("test_nodeKinds", test_nodeKinds),
708719
("test_nodeNames", test_nodeNames),
709720
("test_creatingAnEmptyDocumentAndNode", test_creatingAnEmptyDocumentAndNode),
721+
("test_creatingAnEmptyDTD", test_creatingAnEmptyDTD),
710722
]
711723
}
712724
}

0 commit comments

Comments
 (0)