Skip to content

Commit e7c2d39

Browse files
committed
Added tests for NSOperatingSystemVersion
1 parent df47b8f commit e7c2d39

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Foundation/NSProcessInfo.swift

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public struct NSOperatingSystemVersion {
2020
public var majorVersion: Int
2121
public var minorVersion: Int
2222
public var patchVersion: Int
23+
2324
public init() {
2425
self.init(majorVersion: 0, minorVersion: 0, patchVersion: 0)
2526
}
@@ -31,11 +32,7 @@ public struct NSOperatingSystemVersion {
3132
}
3233
}
3334

34-
extension NSOperatingSystemVersion : Comparable {
35-
public init(_ majorVersion: Int, _ minorVersion: Int, _ patchVersion: Int) {
36-
self.init(majorVersion: majorVersion, minorVersion: minorVersion, patchVersion: patchVersion)
37-
}
38-
}
35+
extension NSOperatingSystemVersion : Comparable {}
3936

4037
public func ==(lhs: NSOperatingSystemVersion, rhs: NSOperatingSystemVersion) -> Bool {
4138
let lhsTuple = (lhs.majorVersion, lhs.minorVersion, lhs.patchVersion)

TestFoundation/TestNSProcessInfo.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ class TestNSProcessInfo : XCTestCase {
3434

3535
let version = processInfo.operatingSystemVersion
3636
XCTAssertNotNil(version.majorVersion != 0)
37+
38+
XCTAssertEqual(NSOperatingSystemVersion(), NSOperatingSystemVersion())
39+
XCTAssertEqual(NSOperatingSystemVersion(majorVersion: 0, minorVersion: 0, patchVersion: 0), NSOperatingSystemVersion())
40+
XCTAssertLessThan(NSOperatingSystemVersion(majorVersion: 0, minorVersion: 0, patchVersion: 1), NSOperatingSystemVersion(majorVersion: 0, minorVersion: 0, patchVersion: 2))
41+
XCTAssertGreaterThan(NSOperatingSystemVersion(majorVersion: 0, minorVersion: 0, patchVersion: 2), NSOperatingSystemVersion(majorVersion: 0, minorVersion: 0, patchVersion: 1)) //Guards against false positives in LT test
3742
}
3843

3944
func test_processName() {

0 commit comments

Comments
 (0)