Skip to content

Commit 879b4d8

Browse files
author
Maxim Moiseev
committed
Migrating XCTest to Swift 3
Includes both automatic changes made by migrator and manual fixes after that.
1 parent 824862a commit 879b4d8

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

Sources/XCTest/XCTAssert.swift

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private enum _XCTAssertion {
4949
private enum _XCTAssertionResult {
5050
case Success
5151
case ExpectedFailure(String?)
52-
case UnexpectedFailure(ErrorType)
52+
case UnexpectedFailure(ErrorProtocol)
5353

5454
var expected: Bool {
5555
switch (self) {
@@ -155,7 +155,7 @@ private func _XCTEvaluateAssertion(assertion: _XCTAssertion, @autoclosure messag
155155
///
156156
/// Now calling failures in `AssertEmpty` will be reported in the file and on
157157
/// the line that the assert function is *called*, not where it is defined.
158-
public func XCTAssert(@autoclosure expression: () throws -> BooleanType, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
158+
public func XCTAssert(@autoclosure expression: () throws -> Boolean, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
159159
XCTAssertTrue(expression, message, file: file, line: line)
160160
}
161161

@@ -214,18 +214,18 @@ public func XCTAssertEqual<T, U: Equatable>(@autoclosure expression1: () throws
214214
}
215215
}
216216

217-
public func XCTAssertEqualWithAccuracy<T: FloatingPointType>(@autoclosure expression1: () throws -> T, @autoclosure _ expression2: () throws -> T, accuracy: T, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
217+
public func XCTAssertEqualWithAccuracy<T: FloatingPoint>(@autoclosure expression1: () throws -> T, @autoclosure _ expression2: () throws -> T, accuracy: T, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
218218
_XCTEvaluateAssertion(.EqualWithAccuracy, message: message, file: file, line: line) {
219219
let (value1, value2) = (try expression1(), try expression2())
220-
if abs(value1.distanceTo(value2)) <= abs(accuracy.distanceTo(T(0))) {
220+
if abs(value1.distance(to: value2)) <= abs(accuracy.distance(to: T(0))) {
221221
return .Success
222222
} else {
223223
return .ExpectedFailure("(\"\(value1)\") is not equal to (\"\(value2)\") +/- (\"\(accuracy)\")")
224224
}
225225
}
226226
}
227227

228-
public func XCTAssertFalse(@autoclosure expression: () throws -> BooleanType, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
228+
public func XCTAssertFalse(@autoclosure expression: () throws -> Boolean, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
229229
_XCTEvaluateAssertion(.False, message: message, file: file, line: line) {
230230
let value = try expression()
231231
if !value.boolValue {
@@ -346,10 +346,10 @@ public func XCTAssertNotEqual<T, U: Equatable>(@autoclosure expression1: () thro
346346
}
347347
}
348348

349-
public func XCTAssertNotEqualWithAccuracy<T: FloatingPointType>(@autoclosure expression1: () throws -> T, @autoclosure _ expression2: () throws -> T, _ accuracy: T, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
349+
public func XCTAssertNotEqualWithAccuracy<T: FloatingPoint>(@autoclosure expression1: () throws -> T, @autoclosure _ expression2: () throws -> T, _ accuracy: T, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
350350
_XCTEvaluateAssertion(.NotEqualWithAccuracy, message: message, file: file, line: line) {
351351
let (value1, value2) = (try expression1(), try expression2())
352-
if abs(value1.distanceTo(value2)) > abs(accuracy.distanceTo(T(0))) {
352+
if abs(value1.distance(to: value2)) > abs(accuracy.distance(to: T(0))) {
353353
return .Success
354354
} else {
355355
return .ExpectedFailure("(\"\(value1)\") is equal to (\"\(value2)\") +/- (\"\(accuracy)\")")
@@ -368,7 +368,7 @@ public func XCTAssertNotNil(@autoclosure expression: () throws -> Any?, @autoclo
368368
}
369369
}
370370

371-
public func XCTAssertTrue(@autoclosure expression: () throws -> BooleanType, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
371+
public func XCTAssertTrue(@autoclosure expression: () throws -> Boolean, @autoclosure _ message: () -> String = "", file: StaticString = #file, line: UInt = #line) {
372372
_XCTEvaluateAssertion(.True, message: message, file: file, line: line) {
373373
let value = try expression()
374374
if value.boolValue {
@@ -385,9 +385,9 @@ public func XCTFail(message: String = "", file: StaticString = #file, line: UInt
385385
}
386386
}
387387

388-
public func XCTAssertThrowsError<T>(@autoclosure expression: () throws -> T, _ message: String = "", file: StaticString = #file, line: UInt = #line, _ errorHandler: (error: ErrorType) -> Void = { _ in }) {
388+
public func XCTAssertThrowsError<T>(@autoclosure expression: () throws -> T, _ message: String = "", file: StaticString = #file, line: UInt = #line, _ errorHandler: (error: ErrorProtocol) -> Void = { _ in }) {
389389
_XCTEvaluateAssertion(.ThrowsError, message: message, file: file, line: line) {
390-
var caughtErrorOptional: ErrorType?
390+
var caughtErrorOptional: ErrorProtocol?
391391
do {
392392
_ = try expression()
393393
} catch {

Sources/XCTest/XCTimeUtilities.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ private func currentTimeIntervalSinceReferenceTime() -> TimeInterval {
2424
var tv = timeval()
2525
let currentTime = withUnsafeMutablePointer(&tv, { (t: UnsafeMutablePointer<timeval>) -> TimeInterval in
2626
gettimeofday(t, nil)
27-
return TimeInterval(t.memory.tv_sec) + TimeInterval(t.memory.tv_usec) / 1000000.0
27+
return TimeInterval(t.pointee.tv_sec) + TimeInterval(t.pointee.tv_usec) / 1000000.0
2828
})
2929
return currentTime
3030
}

XCTest.xcodeproj/project.pbxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@
276276
5B5D86D21BBC74AD00234F36 /* Project object */ = {
277277
isa = PBXProject;
278278
attributes = {
279+
LastSwiftMigration = 0730;
279280
LastSwiftUpdateCheck = 0710;
280281
LastUpgradeCheck = 0710;
281282
ORGANIZATIONNAME = Apple;

0 commit comments

Comments
 (0)