Skip to content

Prevent adding extra Snippets path component when converting to symbol graph symbols #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2023
Merged

Prevent adding extra Snippets path component when converting to symbol graph symbols #41

merged 2 commits into from
Jan 10, 2023

Conversation

bitjammer
Copy link
Contributor

@bitjammer bitjammer commented Jan 9, 2023 •
edited
Loading

rdar://104044227

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@bitjammer bitjammer changed the title Prevent adding extra Snippets path component when converting to sym… Prevent adding extra Snippets path component when converting to symbol graph symbols Jan 9, 2023
@bitjammer
Copy link
Contributor Author

@swift-ci Please test

ethan-kusters
ethan-kusters approved these changes Jan 9, 2023
View reviewed changes
@bitjammer
Copy link
Contributor Author

bitjammer commented Jan 9, 2023 •
edited
Loading

Linux test failed with:

/home/build-user/swift-docc-plugin/swift-docc/Sources/generate-symbol-graph/main.swift:13:18: error: module 'SwiftDocC' was not compiled for testing
@testable import SwiftDocC
~~~~~~~~~~       ^

A separate problem–waiting on a fix for that in #42

@bitjammer
Copy link
Contributor Author

@swift-ci Please test

@bitjammer bitjammer merged commit 252c51b into swiftlang:main Jan 10, 2023
@bitjammer bitjammer deleted the acgarland/rdar-104044227-remove-extra-snippets-path-component branch January 10, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-kusters ethan-kusters ethan-kusters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitjammer @ethan-kusters