Skip to content

Commit c121978

Browse files
author
Dobromir Hristov
committed
refactor: extract reusable utility
1 parent 4ff3d77 commit c121978

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

src/components/CardCover.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@
1919

2020
<script>
2121
import imageAsset from 'docc-render/mixins/imageAsset';
22-
import { normalizeAssetUrl } from 'docc-render/utils/assets';
23-
24-
const toCSSUrl = url => (url ? `url('${normalizeAssetUrl(url)}')` : undefined);
22+
import { toCSSUrl } from 'docc-render/utils/assets';
2523
2624
export default {
2725
name: 'CardCover',

src/components/Tutorial/Hero.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ import LinkableElement from 'docc-render/components/LinkableElement.vue';
7373
7474
import GenericModal from 'docc-render/components/GenericModal.vue';
7575
import PlayIcon from 'theme/components/Icons/PlayIcon.vue';
76-
import { normalizeAssetUrl } from 'docc-render/utils/assets';
76+
import { normalizeAssetUrl, toCSSUrl } from 'docc-render/utils/assets';
7777
import HeroMetadata from './HeroMetadata.vue';
7878
7979
export default {
@@ -140,14 +140,14 @@ export default {
140140
variant.traits.includes('light')
141141
));
142142
143-
return lightVariant ? normalizeAssetUrl(lightVariant.url) : '';
143+
return (lightVariant || {}).url;
144144
},
145145
projectFilesUrl() {
146146
return this.projectFiles ? normalizeAssetUrl(this.references[this.projectFiles].url) : null;
147147
},
148148
bgStyle() {
149149
return {
150-
backgroundImage: `url('${this.backgroundImageUrl}')`,
150+
backgroundImage: toCSSUrl(this.backgroundImageUrl),
151151
};
152152
},
153153
xcodeRequirementData() {

src/utils/assets.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,10 @@ export function normalizeAssetUrl(url) {
7575
}
7676
return pathJoin([baseUrl, url]);
7777
}
78+
79+
/**
80+
* Transforms a URL string into a normalized css `url(/path)` format.
81+
* @param {String} url
82+
* @returns {string|undefined}
83+
*/
84+
export function toCSSUrl(url) { return url ? `url('${normalizeAssetUrl(url)}')` : undefined; }

0 commit comments

Comments
 (0)