Skip to content

if "Hide Deprecated" chosen, hide labels when all children are deprecated #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dobromir-hristov
Copy link
Contributor

Bug/issue #, if applicable: 93506254

Summary

Fixes issues with labels being shown when "Hide Deprecated" is picked.

Dependencies

NA

Testing

Steps:

  1. Start searching for a Label that has all deprecated items
  2. Assert you can see the label
  3. Choose "Hide Deprecated" tag
  4. Assert the label and children are no longer shown.
  5. Assert there are no empty parents without relation to the search.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

…are deprecated. Show label related to each search match.
Copy link
Member

@marinaaisa marinaaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved. Thanks Dobri! 👏 I understand that test are still left, anyways approving already

@dobromir-hristov dobromir-hristov marked this pull request as ready for review July 26, 2022 10:53
Copy link
Member

@marinaaisa marinaaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the tests, thanks Dobri!

@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

@dobromir-hristov dobromir-hristov merged commit e205771 into swiftlang:main Aug 1, 2022
@dobromir-hristov dobromir-hristov deleted the dhristov/r93506254-properly-hide-items-when-hide-deprecated branch August 1, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants