Skip to content

Prevent NavigatorCard from re-render when fetching data #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marinaaisa
Copy link
Member

Bug/issue #130012107, if applicable:

Summary

Prevent NavigatorCard from re-render when fetching data

Dependencies

NA

Testing

Steps:

  • Run any doccarchive
  • Assert that there is no performance issues with the navigator when fetching data

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@marinaaisa marinaaisa requested review from mportiz08 and hqhhuang June 17, 2024 17:32
@marinaaisa
Copy link
Member Author

@swift-ci test

@marinaaisa marinaaisa merged commit f018bdf into swiftlang:main Jun 18, 2024
1 check passed
@marinaaisa marinaaisa deleted the r130012107/navigator-card-fetching branch June 18, 2024 17:40
hqhhuang added a commit to hqhhuang/swift-docc-render that referenced this pull request Jul 23, 2024
hqhhuang added a commit to hqhhuang/swift-docc-render that referenced this pull request Jul 23, 2024
hqhhuang added a commit to hqhhuang/swift-docc-render that referenced this pull request Oct 28, 2024
…tlang#865

revert "Prevent NavigatorCard from re-render when fetching data" swiftlang#865
hqhhuang added a commit that referenced this pull request Oct 31, 2024
…#907) rdar://130779044

revert "Prevent NavigatorCard from re-render when fetching data" #865 (#907) rdar://130779044
hqhhuang added a commit to hqhhuang/swift-docc-render that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants