Skip to content

[6.0] Fix loading performance for pages with many links caused by excessive re-computation #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

[6.0] Fix loading performance for pages with many links caused by excessive re-computation #910

merged 1 commit into from
Nov 4, 2024

Conversation

mportiz08
Copy link
Contributor

  • Explanation: Fixes performance regression where pages with large number of links may load slowly
  • Scope: Impacts all pages with large numbers of links
  • Issue: rdar://139214223
  • Risk: Medium, code that impacts all linking to reference
  • Testing: Updated unit tests, manually tested content with large numbers of links, previously tested the same cherry-picked commit on main.
  • Reviewer: @hqhhuang
  • Original PR: Fix loading performance for pages with many links caused by excessive re-computation #900

@mportiz08
Copy link
Contributor Author

@swift-ci test

@mportiz08 mportiz08 merged commit b14e61a into swiftlang:release/6.0-20241104 Nov 4, 2024
1 check passed
@mportiz08 mportiz08 deleted the 6.0-20241104/fix-perf-regression-on-pages-with-many-links branch November 4, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

@eango eango Awaiting requested review from eango

@anferbui anferbui Awaiting requested review from anferbui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mportiz08 @franklinsch