Remove linux-specific code and enable tests that pass on linux

Author: finagolfin

Sources/SwiftDocC/Indexing/Navigator/NavigatorIndex.swift

@@ -11,12 +11,6 @@
 import Foundation
 import Crypto
 
-// Fallback solution for Linux as it has no PropertyList support.
-#if os(Linux)
-fileprivate typealias PropertyListEncoder = JSONEncoder
-fileprivate typealias PropertyListDecoder = JSONDecoder
-#endif
-
 /// A protocol to provide data to be indexed.
 public protocol RenderNodeProvider {
     /// Get an instance of `RenderNode` to be processed by the index.

Sources/SwiftDocC/Infrastructure/Workspace/LocalFileSystemDataProvider.swift

@@ -31,12 +31,7 @@ public struct LocalFileSystemDataProvider: DocumentationWorkspaceDataProvider, F
     /// - Returns: A virtual file system that describe the file and directory structure within the given URL.
     private static func buildTree(root: URL) throws -> FSNode {
         var children: [FSNode] = []
-        #if os(Linux)
-        // Resource values and enumeration options aren't implemented on Linux.
-        let childURLs = try FileManager.default.contentsOfDirectory(at: root, includingPropertiesForKeys: [URLResourceKey.isDirectoryKey], options: .init())
-        #else
         let childURLs = try FileManager.default.contentsOfDirectory(at: root, includingPropertiesForKeys: [URLResourceKey.isDirectoryKey], options: .skipsHiddenFiles)
-        #endif
 
         for url in childURLs {
             if FileManager.default.directoryExists(atPath: url.path) {

Sources/SwiftDocC/Model/Rendering/RenderContext.swift

@@ -60,25 +60,14 @@ public struct RenderContext {
                 renderReferenceDependencies: dependencies
             )
         }
-        
-        #if os(macOS) || os(iOS)
-        // Concurrently render content on macOS & iOS
+
         let results: [(reference: ResolvedTopicReference, content: RenderReferenceStore.TopicContent)] = references.concurrentPerform { reference, results in
             results.append((reference, renderContentFor(reference)))
         }
         for result in results {
             topics[result.reference] = result.content
         }
-        
-        #elseif os(Linux)
-        // Serially render on Linux
-        references.forEach {
-            topics[$0] = renderContentFor($0)
-        }
-        #else
-        #error("Unexpected platform.")
-        #endif
-        
+
         let assets = documentationContext.assetManagers
             .reduce(into: [AssetReference: DataAsset]()) { (storage, element) in
                 let (bundleIdentifer, assetManager) = element

Sources/SwiftDocC/Utility/LinuxBundleShims.swift

@@ -700,12 +700,6 @@ class ConvertServiceTests: XCTestCase {
     }
 
     func testReturnsRenderReferenceStoreWhenRequestedForOnDiskBundleWithUncuratedArticles() throws {
-        #if os(Linux)
-        throw XCTSkip("""
-        Skipped on Linux due to an issue in Foundation.Codable where dictionaries are sometimes getting encoded as \
-        arrays. (SR-15036)
-        """)
-        #else
         let (testBundleURL, _, _) = try testBundleAndContext(
             copying: "TestBundle",
             excludingPaths: [
@@ -826,16 +820,9 @@ class ConvertServiceTests: XCTestCase {
                 }
             }
         )
-        #endif
     }
 
     func testNoRenderReferencesToNonLinkableNodes() throws {
-        #if os(Linux)
-        throw XCTSkip("""
-        Skipped on Linux due to an issue in Foundation.Codable where dictionaries are sometimes getting encoded as \
-        arrays. (SR-15036)
-        """)
-        #else
         let (testBundleURL, _, _) = try testBundleAndContext(
             copying: "TestBundle",
             excludingPaths: [
@@ -876,16 +863,9 @@ class ConvertServiceTests: XCTestCase {
             }
 
         )
-        #endif
     }
 
     func testReturnsRenderReferenceStoreWhenRequestedForOnDiskBundleWithCuratedArticles() throws {
-        #if os(Linux)
-        throw XCTSkip("""
-        Skipped on Linux due to an issue in Foundation.Codable where dictionaries are sometimes getting encoded as \
-        arrays. (SR-15036)
-        """)
-        #else
         let (testBundleURL, _, _) = try testBundleAndContext(
             // Use a bundle that contains only articles, one of which is declared as the TechnologyRoot and curates the
             // other articles.
@@ -939,7 +919,6 @@ class ConvertServiceTests: XCTestCase {
                 )
             }
         )
-        #endif
     }
 
     func testConvertPageWithLinkResolving() throws {

Tests/SwiftDocCTests/DocumentationService/ConvertService/ConvertServiceTests.swift

@@ -236,7 +236,6 @@ Root
     }
 
     func testNavigationTreeLargeDumpAndReadAsync() throws {
-#if !os(Linux)
         let targetURL = URL(fileURLWithPath: NSTemporaryDirectory()).appendingPathComponent(UUID().uuidString)
         try FileManager.default.createDirectory(at: targetURL, withIntermediateDirectories: true, attributes: nil)
         defer {
@@ -279,11 +278,9 @@ Root
         }
 
         XCTAssertTrue(validateTree(node: readTreePresentationIdentifier.root, validator: presentationIdentifierValidator), "The tree lacks the presentation identifier.")
-#endif
     }
 
     func testNavigatorIndexGenerationEmpty() throws {
-#if !os(Linux)
         let targetURL = URL(fileURLWithPath: NSTemporaryDirectory()).appendingPathComponent(UUID().uuidString)
         try FileManager.default.createDirectory(at: targetURL, withIntermediateDirectories: true, attributes: nil)
         defer {
@@ -300,11 +297,9 @@ Root
 
         let readTree = NavigatorTree()
         XCTAssertThrowsError(try readTree.read(from: indexURL, interfaceLanguages: [.swift], timeout: 0.25, queue: DispatchQueue.main, broadcast: nil))
-#endif
     }
 
     func testNavigatorIndexGenerationOneNode() throws {
-#if !os(Linux)
         let targetURL = URL(fileURLWithPath: NSTemporaryDirectory()).appendingPathComponent(UUID().uuidString)
         try FileManager.default.createDirectory(at: targetURL, withIntermediateDirectories: true, attributes: nil)
         defer {
@@ -331,11 +326,9 @@ Root
         XCTAssert(counter == 1, "The broadcast callback has to be called at exactly 1 time.")
         XCTAssertEqual(original.root.countItems(), readTree.root.countItems())
         XCTAssertTrue(compare(lhs: original.root, rhs: readTree.root))
-#endif
     }
 
     func testNavigatorIndexGenerationOperator() throws {
-#if !os(Linux)
         let operatorURL = Bundle.module.url(
             forResource: "Operator", withExtension: "json", subdirectory: "Test Resources")!
 
@@ -353,7 +346,6 @@ Root
         builder.finalize()
 
         XCTAssertNotNil(builder.navigatorIndex)
-#endif
     }
 
     func testNavigatorIndexGeneration() throws {
@@ -513,7 +505,6 @@ Root
     }
 
     func testNavigatorIndexGenerationWithLanguageGrouping() throws {
-#if !os(Linux)
         let (bundle, context) = try testBundleAndContext(named: "TestBundle")
         let renderContext = RenderContext(documentationContext: context, bundle: bundle)
         let converter = DocumentationContextConverter(bundle: bundle, context: context, renderContext: renderContext)
@@ -557,7 +548,6 @@ Root
 
         assertUniqueIDs(node: navigatorIndex.navigatorTree.root)
         assertEqualDumps(navigatorIndex.navigatorTree.root.dumpTree(), try testTree(named: "testNavigatorIndexGenerationWithLanguageGrouping"))
-#endif
     }
 
 
@@ -625,7 +615,6 @@ Root
     }
 
     func testNavigatorIndexAvailabilityGeneration() throws {
-        #if !os(Linux)
         let (bundle, context) = try testBundleAndContext(named: "TestBundle")
         let renderContext = RenderContext(documentationContext: context, bundle: bundle)
         let converter = DocumentationContextConverter(bundle: bundle, context: context, renderContext: renderContext)
@@ -720,11 +709,9 @@ Root
         let availabilityDB = try navigatorIndex.environment.openDatabase(named: "availability")
         XCTAssertThrowsError(try availabilityDB.put(key: "content", value: "test"))
         XCTAssertNil(availabilityDB.get(type: String.self, forKey: "content"))
-        #endif
     }
 
     func testNavigatorIndexDifferenHasherGeneration() throws {
-        #if !os(Linux)
         let (bundle, context) = try testBundleAndContext(named: "TestBundle")
         let renderContext = RenderContext(documentationContext: context, bundle: bundle)
         let converter = DocumentationContextConverter(bundle: bundle, context: context, renderContext: renderContext)
@@ -780,8 +767,6 @@ Root
         let sideClassNode = try XCTUnwrap(search(node: navigatorIndex.navigatorTree.root) { navigatorIndex.path(for: $0.id!) == "/documentation/sidekit/sideclass" })
         let availabilities = navigatorIndex.availabilities(for: sideClassNode.item.availabilityID)
         XCTAssertEqual(availabilities.count, 1)
-        
-        #endif
     }
 
     func testPlatformVersion() {
@@ -1133,7 +1118,6 @@ Root
     }
 
     func testNavigatorIndexAsReadOnlyFile() throws {
-        #if !os(Linux)
         let (bundle, context) = try testBundleAndContext(named: "TestBundle")
         let converter = DocumentationNodeConverter(bundle: bundle, context: context)
 
@@ -1164,7 +1148,6 @@ Root
 
         // Make sure we throw if an index can't be opened even after the fallback, avoiding entering an infinite loop.
         XCTAssertThrowsError(try NavigatorIndex(url: targetURL, readNavigatorTree: false))
-        #endif
     }
 
     func testNavigatorTitle() throws {